Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added around 270 words in the monolingual dictionary #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ManitK
Copy link

@ManitK ManitK commented Dec 28, 2019

No description provided.

@dolphingarlic
Copy link

You deleted the entire dix. You should rather add the new words to their respective sections instead of deleting the whole thing

@ManitK
Copy link
Author

ManitK commented Dec 28, 2019

Oh shite sorry

Copy link

@dolphingarlic dolphingarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't just copy and paste words from the apertium-eng dix since many of those words may not be defined in Indonesian

apertium-ind.ind.dix Outdated Show resolved Hide resolved
apertium-ind.ind.dix Show resolved Hide resolved
apertium-ind.ind.dix Outdated Show resolved Hide resolved
apertium-ind.ind.dix Outdated Show resolved Hide resolved
apertium-ind.ind.dix Outdated Show resolved Hide resolved
apertium-ind.ind.dix Outdated Show resolved Hide resolved
apertium-ind.ind.dix Outdated Show resolved Hide resolved
Copy link

@dolphingarlic dolphingarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many of these words aren't even in the Indonesian language. Please check your additions properly

<e r="RL"><p><l>'s</l> <r><s n="n"/><s n="acr"/><s n="sg"/><j/>'s<s n="gen"/></r></p></e>
<e><p><l>s</l> <r><s n="n"/><s n="acr"/><s n="pl"/></r></p></e>
<e r="RL"><p><l>s'</l> <r><s n="n"/><s n="acr"/><s n="pl"/><j/>'s<s n="gen"/></r></p></e>
</pardef>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you still haven't indented like the rest of the file

@@ -15416,4 +15433,284 @@
<e><par n="separ"/></e>
<e><par n="guionet"/></e>
</section>
<!-- Acronyms -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should place these in a section

@@ -15416,4 +15433,284 @@
<e><par n="separ"/></e>
<e><par n="guionet"/></e>
</section>
<!-- Acronyms -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also these words should be placed in the same place as all the other words

<e lm="Hamàs"><i>Hamàs</i><par n="Linux__np"/></e>
<e lm="Hansa"><i>Hansa</i><par n="Wikipedia__np"/></e>
<e lm="Iurbentia"><i>Iurbentia</i><par n="Wikipedia__np"/></e>
<e lm="Jackass"><i>Jackass</i><par n="Linux__np"/></e>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a proper noun?

<e><p><l>s</l> <r><s n="n"/><s n="acr"/><s n="pl"/></r></p></e>
<e r="RL"><p><l>s'</l> <r><s n="n"/><s n="acr"/><s n="pl"/><j/>'s<s n="gen"/></r></p></e>
</pardef>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These paradigms should be placed by all the other paradigms

<e lm="Adobe Acrobat">i>Adobe<b/>Acrobat</i><par n="Linux__np"/></e>
<e lm="Adobe After Effects"><i>Adobe<b/>After<b/>Effects</i><par n="Linux__np"/></e>
<e lm="Adobe Audition"><i>Adobe<b/>Audition</i><par n="Linux__np"/></e>
<e lm="Adobe Dreamviewer”><i>Adobe<b/>Dreamviewer</i><par n="Linux__np"/></e>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing a matching "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants