ice_dyn_shared: add 'viscous_coeffs_and_rep_pressure_T' subroutine #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-blain
force-pushed
the
cgrid-visc-coef-t
branch
from
ed8cee9
to
8630a99
Compare
Add a subroutine mimicking what 'viscous_coeffs_and_rep_pressure' does, but at a single location. Name it '*_T' since it's going to be used to compute the viscous coefficients and replacement pressure at the T point.
phil-blain
force-pushed
the
cgrid-visc-coef-t
branch
from
8630a99
to
d2c301a
Compare
apcraig
requested review from
dabail10,
daveh150,
eclare108213 and
rallard77
|
Looks like this fails to compile in github actions. @phil-blain, can you take a look. |
|
Yeah - it's actually JF's commit which makes the build fail. I'll let him fix that (I guess tomorrow), then I'll rebase my branch. |
|
I merged a fix to cgridDEV, but the checks on this PR still fail. I wonder why github doesn't merge this PR to the current branch being merged to. I restarted github actions manually, and it still fails with the old error. So I guess the fix has to be merged onto this branch. |
|
I tested this offline last night and it seems fine. all still bit-for-bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a subroutine mimicking what 'viscous_coeffs_and_rep_pressure' does,
but at a single location.
Name it '*_T' since it's going to be used to compute the viscous
coefficients and replacement pressure at the T point.