Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added option to rebuild model up to specific readout layer #396

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

added option to rebuild model up to specific readout layer #396

wants to merge 12 commits into from

Conversation

M-R-Schaefer
Copy link
Contributor

No description provided.

@M-R-Schaefer M-R-Schaefer added the enhancement New feature or request label Jan 20, 2025
@M-R-Schaefer M-R-Schaefer requested a review from PythonFZ January 20, 2025 11:54
PythonFZ
PythonFZ reviewed Feb 19, 2025
View reviewed changes
apax/nn/builder.py Outdated
@@ -80,7 +80,7 @@ def build_descriptor(
):
raise NotImplementedError("use a subclass to facilitate this")

def build_readout(self, head_config, is_feature_fn=False):
def build_readout(self, head_config, is_feature_fn=False, only_use_n_layers=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only_use_n_layers is a bit difficult of a name. Maybe type hint None|int to show that you can select the layers and it is not of boolean type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PythonFZ PythonFZ PythonFZ left review comments

@Tetracarbonylnickel Tetracarbonylnickel Awaiting requested review from Tetracarbonylnickel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-R-Schaefer @PythonFZ