use znh5md v0.3 #292
Merged
use znh5md v0.3 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-R-Schaefer
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
looks good, I appreciate the leaner API.
You mentioned that it is now possible to keep the H5 file open during the simulation, eliminating some issues we were having. Does the current implementation already make use of this? if not I can work it out in a different branch.
Yest, this is already possible, e.g. as highlighted in this test but my suggestion would be:
What do you think? |
|
sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.