-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-1346] Add contribution guidelines to the website #1356
Closed
Closed
Changes from 17 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
06238fb
Modify the Community page
corneadoug cb87608
Add forgotten license headers
corneadoug acc68b5
Add contribution Guidelines to the website
corneadoug 5f7e2bd
Add a side menu template
corneadoug c933c19
Add zeppelin-web contribution page
corneadoug 306ae06
Add zeppelin-web GPG menu
corneadoug 666f3ec
Add first Zeppelin-web best practices page
corneadoug 81493ab
Change Side Menu style
corneadoug 94d653b
Fix typos
corneadoug e7209ea
Add docs contribution guide
AhyoungRyu 8f69f28
Add GUI integration tests CLI
corneadoug 318c4c1
Add section for 'For committers only'
AhyoungRyu 9882670
Allows contribution page without side Menu
corneadoug e0b4c8d
change name of good practice file
corneadoug a4c924b
Remove 'menu' property
AhyoungRyu e34fc64
fix typo in front-end doc
corneadoug 2d62d20
Merge pull request #6 from AhyoungRyu/add/ContributeCategory-ahyoung
corneadoug 934afd9
Change Zeppelin to Apache Zeppelin in general.md
corneadoug 79d15a3
Add Contribution Guidelines to SubMenu
corneadoug a469d52
Extend pages_list to support multi group
corneadoug d31cf3f
Improve CSS for the content
corneadoug 9169c68
Improve wording and spacing in contribution docs
corneadoug 1a45b92
Improve margin for small devices
corneadoug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
<!-- | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
|
||
## How to contribute | ||
|
||
There are multiple ways you can contribute to the project. | ||
And help is always welcome! | ||
|
||
### Issue Tracker | ||
|
||
Apache Zeppelin uses JIRA as an [Issue Tracker](https://issues.apache.org/jira/browse/ZEPPELIN). | ||
Don't hesitate to report new bugs and improvements ideas. | ||
|
||
#### Contribute to the source code | ||
|
||
We like to get code contributions through Pull Requests on our [Github Mirror](https://github.com/apache/zeppelin). | ||
|
||
But before starting, please read our [Contribution guidelines](/contribution/general.html), it will give | ||
you important information about our review process, and pointers on how to make a good code contribution. | ||
|
||
You can visit our [Issue Tracker](https://issues.apache.org/jira/browse/ZEPPELIN) to find issues to resolve, | ||
and if your are a newcomer and don't know where to get started, we have set some [beginner issues](https://issues.apache.org/jira/browse/ZEPPELIN-1245?jql=project%20%3D%20ZEPPELIN%20AND%20status%20%3D%20Open%20AND%20labels%20%3D%20beginner). | ||
|
||
#### Other contributions | ||
|
||
Not much of a coder? There are other ways to help out: | ||
|
||
* Documentation and website improvements are always welcome | ||
* Helping each other by answering questions on the Mailing List | ||
* Participating in reviewing contributions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<!-- | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
|
||
## Mailing list | ||
|
||
Get help using Apache Zeppelin or contribute to the project on our mailing lists: | ||
|
||
* __Users :__ [subscribe](mailto:users-subscribe@zeppelin.apache.org?subject=send this email to subscribe), [unsubscribe](mailto:users-unsubscribe@zeppelin.apache.org?subject=send this email to unsubscribe), [archives](http://mail-archives.apache.org/mod_mbox/zeppelin-users/) | ||
<br/> | ||
for usage questions, help, and announcements. | ||
* __Dev :__ [subscribe](mailto:dev-subscribe@zeppelin.apache.org?subject=send this email to subscribe), [unsubscribe](mailto:dev-unsubscribe@zeppelin.apache.org?subject=send this email to unsubscribe), [archives](http://mail-archives.apache.org/mod_mbox/zeppelin-dev/) | ||
<br/> | ||
for people wanting to contribute to the project. | ||
* __Commits :__ [subscribe](mailto:commits-subscribe@zeppelin.apache.org?subject=send this email to subscribe), [unsubscribe](mailto:commits-unsubscribe@zeppelin.apache.org?subject=send this email to unsubscribe), [archives](http://mail-archives.apache.org/mod_mbox/zeppelin-commits/) | ||
<br/> | ||
for commit messages and patches. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<div class="row"> | ||
{% if page.menu %} | ||
<div class="sideMenu col-md-3"> | ||
{% assign pages_list = site.pages %} | ||
{% assign group = page.menu %} | ||
{% include JB/pages_list %} | ||
</div> | ||
<div class="col-md-9"> | ||
{{ content }} | ||
</div> | ||
{% else %} | ||
<div class="col-md-12"> | ||
{{ content }} | ||
</div> | ||
{% endif %} | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
layout: default | ||
--- | ||
{% include JB/setup %} | ||
{% include themes/zeppelin/sideMenu.html %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
=begin | ||
Jekyll tag to include Markdown text from _includes directory preprocessing with Liquid. | ||
Usage: | ||
{% markdown <filename> %} | ||
Dependency: | ||
- kramdown | ||
=end | ||
module Jekyll | ||
class MarkdownTag < Liquid::Tag | ||
def initialize(tag_name, text, tokens) | ||
super | ||
@text = text.strip | ||
end | ||
require "kramdown" | ||
def render(context) | ||
tmpl = File.read File.join Dir.pwd, "_includes", @text | ||
site = context.registers[:site] | ||
tmpl = (Liquid::Template.parse tmpl).render site.site_payload | ||
html = Kramdown::Document.new(tmpl).to_html | ||
end | ||
end | ||
end | ||
Liquid::Template.register_tag('markdown', Jekyll::MarkdownTag) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,170 @@ | ||
--- | ||
layout: sideMenu | ||
title: "Documentation" | ||
description: "" | ||
group: nav-contrib | ||
--- | ||
<!-- | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
|
||
# Contributing to Documentation | ||
|
||
## Dev Mode | ||
Apache Zeppelin is using [Jekyll](https://jekyllrb.com/) which is a static site generator and [Github Pages](https://pages.github.com/) as a site publisher. For the more details, see [help.github.com/articles/about-github-pages-and-jekyll/](https://help.github.com/articles/about-github-pages-and-jekyll/). | ||
|
||
### Requirements | ||
|
||
``` | ||
# ruby --version >= 2.0.0 | ||
# Install Bundler using gem | ||
gem install bundler | ||
|
||
cd $ZEPPELIN_HOME/docs | ||
# Install all dependencies declared in the Gemfile | ||
bundle install | ||
``` | ||
|
||
For the further information about requirements, please see [here](https://help.github.com/articles/setting-up-your-github-pages-site-locally-with-jekyll/#requirements). | ||
|
||
On OS X 10.9, you may need to do | ||
|
||
``` | ||
xcode-select --install | ||
|
||
``` | ||
### Run the website locally | ||
|
||
If you don't want to encounter uglily rendered pages, run the documentation site in your local first. | ||
In `$ZEPPELIN_HOME/docs`, | ||
|
||
``` | ||
bundle exec jekyll serve --watch | ||
``` | ||
|
||
Using the above command, Jekyll will start a web server at `http://localhost:4000` and watch the `/docs` directory to update. | ||
|
||
|
||
## Folder Structure & Components | ||
`docs/` folder is organized like below: | ||
|
||
``` | ||
docs/ | ||
├── _includes/themes/zeppelin | ||
│ ├── _navigation.html | ||
│ └── default.html | ||
├── _layouts | ||
├── _plugins | ||
├── assets/themes/zeppelin -> {ASSET_PATH} | ||
│ ├── bootstrap | ||
│ ├── css | ||
│ ├── img | ||
│ └── js | ||
├── development/ *.md | ||
├── displaysystem/ *.md | ||
├── install/ *.md | ||
├── interpreter/ *.md | ||
├── manual/ *.md | ||
├── quickstart/ *.md | ||
├── rest-api/ *.md | ||
├── security/ *.md | ||
├── storage/ *.md | ||
├── Gemfile | ||
├── Gemfile.lock | ||
├── _config.yml | ||
├── index.md | ||
└── ... | ||
``` | ||
|
||
- `_navigation.html`: the dropdown menu in navbar | ||
- `default.html` & `_layouts/`: define default HTML layout | ||
- `_plugins/`: custom plugin `*.rb` files can be placed in this folder. See [jekyll/plugins](https://jekyllrb.com/docs/plugins/) for the further information. | ||
- `{ASSET_PATH}/css/style.css`: extra css components can be defined | ||
- `{ASSET_PATH}/img/docs-img/`: image files used for document pages can be placed in this folder | ||
- `{ASSET_PATH}/js/`: extra `.js` files can be placed | ||
- `Gemfile`: defines bundle dependencies. They will be installed by `bundle install`. | ||
- `Gemfile.lock`: when you run `bundle install`, bundler will persist all gems name and their version to this file. For the more details, see [Bundle "The Gemfile Lock"](http://bundler.io/v1.10/man/bundle-install.1.html#THE-GEMFILE-LOCK) | ||
- `documentation_group`: `development/`, `displaysystem/`, `install/`, `interpreter/`... | ||
- `_config.yml`: defines configuration options for docs website. See [jekyll/configuration](https://jekyllrb.com/docs/configuration/) for the other available config variables. | ||
- `index.md`: the main page of `http://zeppelin.apache.org/docs/<ZEPPELIN_VERSION>/` | ||
|
||
|
||
### Markdown | ||
Zeppelin documentation pages are written with [Markdown](http://daringfireball.net/projects/markdown/). It is possible to use [GitHub flavored syntax](https://help.github.com/categories/writing-on-github/) and intermix plain HTML. | ||
|
||
### Front matter | ||
Every page contains [YAML front matter](https://jekyllrb.com/docs/frontmatter/) block in their header. Don't forget to wrap the front matter list with triple-dashed lines(`---`) like below. | ||
The document page should start this triple-dashed lines. Or you will face 404 error, since Jekyll can't find the page. | ||
|
||
``` | ||
--- | ||
layout: page | ||
title: "Apache Zeppelin Tutorial" | ||
description: "This tutorial page contains a short walk-through tutorial that uses Apache Spark backend. Please note that this tutorial is valid for Spark 1.3 and higher." | ||
group: quickstart | ||
--- | ||
``` | ||
|
||
- `layout`: the default layout is `page` which is defined in `_layout/page.html`. | ||
- `title`: the title for the document. Please note that if it needs to include `Zeppelin`, it should be `Apache Zeppelin`, not `Zeppelin`. | ||
- `description`: a short description for the document. One or two sentences would be enough. This description also will be shown as an extract sentence when people search pages. | ||
- `group`: a category of the document page | ||
|
||
### Headings | ||
All documents are structured with headings. From these headings, you can automatically generate a **Table of Contents**. There is a simple rule for Zeppelin docs headings. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apache Zeppelin |
||
|
||
``` | ||
# Level-1 heading <- used only for the main title | ||
## Level-2 heading <- start with this | ||
### Level-3 heading | ||
#### Level-4 heading <- won't be converted in TOC from this level | ||
``` | ||
|
||
### Table of contents(TOC) | ||
|
||
``` | ||
<div id="toc"></div> | ||
``` | ||
|
||
Add this line below `# main title` in order to generate a **Table of Contents**. Headings until `### (Level-3 heading)` are included to TOC. | ||
|
||
|
||
Default setting options for TOC are definded in [here](https://github.com/apache/zeppelin/blob/master/docs/assets/themes/zeppelin/js/toc.js#L4). | ||
|
||
|
||
### Adding new pages | ||
If you're going to create new pages, there are some spots you need to add the location of the page. | ||
|
||
- **Dropdown menu in navbar**: add your docs location to [_navigation.html](https://github.com/apache/zeppelin/blob/master/docs/_includes/themes/zeppelin/_navigation.html) | ||
- **Main index**: add your docs below [What is the next?](http://zeppelin.apache.org/docs/latest/#what-is-the-next) section in [index.md](https://github.com/apache/zeppelin/blob/master/docs/index.md) with a short description. No need to do this if the page is for **Interpreters**. | ||
|
||
|
||
## For committers only | ||
### Bumping up version in a new release | ||
|
||
`ZEPPELIN_VERSION` and `BASE_PATH` property in `_config.yml` | ||
|
||
### Deploy to ASF svnpubsub infra | ||
1. generate static website in `./_site` | ||
|
||
``` | ||
# go to /docs under Zeppelin source | ||
bundle exec jekyll build --safe | ||
``` | ||
|
||
2. checkout ASF repo | ||
``` | ||
svn co https://svn.apache.org/repos/asf/zeppelin asf-zeppelin | ||
``` | ||
3. copy `zeppelin/docs/_site` to `asf-zeppelin/site/docs/[VERSION]` | ||
4. ```svn commit``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need to say Apache Zeppelin