[Target] Fix device mask issue and typos #9768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeexyz
requested review from
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
leandron,
MarisaKirisame,
masahi,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
leeexyz
force-pushed
the
main
branch
2 times, most recently
from
09e1f9d to
8683a6a
Compare
masahi
reviewed
Dec 19, 2021
| @@ -217,13 +216,15 @@ class Device(ctypes.Structure): | |||
| "stackvm": 1, | |||
| "cpu": 1, | |||
| "c": 1, | |||
| "hybrid": 1, | |||
There was a problem hiding this comment.
Not sure about it. There is no comment or RFC.
https://github.com/apache/tvm/blob/main/src/target/target_kind.cc#L400-L401
There was a problem hiding this comment.
@masahi there is a legacy thing called TE hybrid script. Probably it’s related?
masahi
approved these changes
Dec 23, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [Target] Fix device mask issue and typos * Skip target hook
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [Target] Fix device mask issue and typos * Skip target hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Community,
Currently, I am working on the Heterogeneous Execution by using
Composite Target. I found it is not included in theDevice.STR2MASKmap and will be failed when compiling with it. So, I added it back and checked all the other targets. Not surprisingly, there are some other issues. Now, I add aConsistency verification caseto help us check it. :)In addition to these, I still have some doubts.
Target System, the device type is saved in each Target (tvm.target.Target.kind). It seems that some attributes of the Device inruntime_ctypes.pyare redundant, such asMASK2STRandSTR2MASK. Then the issue raised here is the same or equaled features located in different locations make things messy. I think we can refactor theRuntime Device.Composite Targetcannot be optimized or even recognized by all relay passes. Ideally, thePartition Passcan perform the partitioning and annotation automatically based on those devices (order does matter), and then select the best op strategy. So my question is: What is the current status forComposite Targetand is anyone working on it?Any help would be much appreciated. :)