Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability fixes to CI runner script #9752

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Usability fixes to CI runner script #9752

merged 2 commits into from
Jan 6, 2022

Conversation

driazati
Copy link
Member

@driazati driazati commented Dec 16, 2021

This fixes the CPU-only docs build (which now runs successfully on the ci-cpu image, tested on a fresh vm via Vagrant) and adds some hints for fixing common errors (and saves them until errors actually occur so they aren't mixed into the long log somewhere).

  • check that a gpu is present when --cpu is not used
  • check that docker is installed
  • check if the build directory exists (e.g. I use ninja outside of Docker but docker uses the same folder to build and wants to generate Makefiles, which makes cmake error out)
  • shorten docker commands by running a file that is also set -x'ed
  • fix help printing

cc @areusch

@driazati driazati marked this pull request as ready for review December 16, 2021 17:08
driazati added a commit to driazati/tvm that referenced this pull request Dec 20, 2021
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these usability improvements @driazati!

@areusch areusch merged commit 0173dc8 into apache:main Jan 6, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
* Usability fixes to CI runner script

* address comments

Co-authored-by: driazati <driazati@users.noreply.github.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Usability fixes to CI runner script

* address comments

Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants