Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIR][Schedule] Analysis functions to check if compute_inline and com… #9743

Merged
merged 2 commits into from
Dec 15, 2021
Merged

[TIR][Schedule] Analysis functions to check if compute_inline and com… #9743

merged 2 commits into from
Dec 15, 2021

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Dec 14, 2021

…pute_inline is allowed

Co-authored-by: Siyuan Feng Hzfengsy@sjtu.edu.cn
Co-authored-by: Bohan Hou 32121147+spectrometerHBH@users.noreply.github.com
Co-authored-by: Hongyi Jin 3231950289@qq.com
Co-authored-by: Ruihang Lai lairuihangdongdong@qq.com
Co-authored-by: Junru Shao junrushao1994@gmail.com
Co-authored-by: Wuwei Lin wuwei@apache.org
Co-authored-by: Xiyou Zhou xiyou@octoml.ai

junrushao
junrushao approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

CC: @comaniac @jcf94 @wrongtest @Hzfengsy @csullivan

@vinx13 @Hzfengsy
@spectrometerHBH @jinhongyii @MasterJH5574 @junrushao @zxybazh
[TIR][Schedule] Analysis functions to check if compute_inline and com…
18407e3 
…pute_inline is allowed

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
@vinx13 vinx13 force-pushed the feat/compute-inline-check branch from 0064c62 to 18407e3 Compare December 14, 2021 21:49
comaniac
comaniac reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just nits.

src/tir/schedule/primitive/compute_at.cc Outdated Show resolved Hide resolved
src/tir/schedule/primitive/compute_inline.cc Outdated Show resolved Hide resolved
src/tir/schedule/primitive/compute_inline.cc Outdated Show resolved Hide resolved
@vinx13 vinx13 force-pushed the feat/compute-inline-check branch from 9dd43cb to f9fdb57 Compare December 14, 2021 22:08
@vinx13 vinx13 force-pushed the feat/compute-inline-check branch from f9fdb57 to 8d075ee Compare December 14, 2021 22:13
comaniac
comaniac approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hzfengsy
Hzfengsy approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hzfengsy Hzfengsy merged commit ecc2e56 into apache:main Dec 15, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@vinx13 @Hzfengsy
@spectrometerHBH @jinhongyii @MasterJH5574 @junrushao @zxybazh @ylc
[TIR][Schedule] Analysis functions to check if compute_inline and com… (
3b9db46 
apache#9743)

* [TIR][Schedule] Analysis functions to check if compute_inline and compute_inline is allowed

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>

* Address comments

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
@vinx13 @Hzfengsy
@spectrometerHBH @jinhongyii @MasterJH5574 @junrushao @zxybazh @yangulei
[TIR][Schedule] Analysis functions to check if compute_inline and com… (
321cba1 
apache#9743)

* [TIR][Schedule] Analysis functions to check if compute_inline and compute_inline is allowed

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>

* Address comments

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
@vinx13 @Hzfengsy
@spectrometerHBH @jinhongyii @MasterJH5574 @junrushao @zxybazh @yangulei
[TIR][Schedule] Analysis functions to check if compute_inline and com… (
46de53c 
apache#9743)

* [TIR][Schedule] Analysis functions to check if compute_inline and compute_inline is allowed

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>

* Address comments

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@vinx13 @Hzfengsy
@spectrometerHBH @jinhongyii @MasterJH5574 @junrushao @zxybazh @ylc
[TIR][Schedule] Analysis functions to check if compute_inline and com… (
3115e85 
apache#9743)

* [TIR][Schedule] Analysis functions to check if compute_inline and compute_inline is allowed

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>

* Address comments

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
@vinx13 @Hzfengsy
@spectrometerHBH @jinhongyii @MasterJH5574 @junrushao @zxybazh
[TIR][Schedule] Analysis functions to check if compute_inline and com… (
c7c5e35 
apache#9743)

* [TIR][Schedule] Analysis functions to check if compute_inline and compute_inline is allowed

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>

* Address comments

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@Hzfengsy Hzfengsy Hzfengsy approved these changes

@comaniac comaniac comaniac approved these changes

@areusch areusch Awaiting requested review from areusch

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@kparzysz-quic kparzysz-quic Awaiting requested review from kparzysz-quic

@masahi masahi Awaiting requested review from masahi

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinx13 @junrushao @comaniac @Hzfengsy