[Runtime] BUG: Fix core-dump in crt graph_executor.c #9155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbs-octoml
requested review from
areusch,
comaniac,
jroesch,
junrushao,
liangfu,
manupak,
merrymercy,
tmoreau89,
tqchen and
yzhliu
as code owners
|
The CI failure on test_meta_schedule_runner.py looks like an unrelated flake. It passed on i386. |
The JSON loader was missing a BeginArray for the "device_index" attribute. That's a 1 line fix. The rest is to add a unit test and make it build. The crt JSON handling is perhaps not our finest code.
mbs-octoml
force-pushed
the
mbs-json-bug
branch
from
8d41f53 to
a4f8c0f
Compare
|
@areusch was hoping someone else would jump in but no luck. Could you do the honors? |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
The JSON loader was missing a BeginArray for the "device_index" attribute. That's a 1 line fix. The rest is to add a unit test and make it build. The crt JSON handling is perhaps not our finest code.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
The JSON loader was missing a BeginArray for the "device_index" attribute. That's a 1 line fix. The rest is to add a unit test and make it build. The crt JSON handling is perhaps not our finest code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON loader was missing a BeginArray for the "device_index" attribute.
That's a 1 line fix. The rest is to add a unit test and make it build.
The crt JSON handling is perhaps not our finest code.