Migrate C Interface API Generation to C++ #9106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested review from
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
liangfu,
manupak,
MarisaKirisame,
masahi,
mbrookhart,
merrymercy,
slyubomirsky,
tmoreau89,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
Mousius
force-pushed
the
interface-api-c++
branch
from
1a78643 to
7c1bead
Compare
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Sep 24, 2021
Google Mock is the mocking/helper framework that gets bundled with Google Test, it used to be separate but now isn't. I ran into the issue of Google Mock not being configured fully in the i386 build of apache#9106, which uses the `HasSubtr` matcher. This PR aims to fully configure Google Mock for use, which is interesting in itself... The headers are installed as part of Ubuntu 18.04's `googletest` package: ```shell $ dpkg -S /usr/include/gmock/ googletest:amd64: /usr/include/gmock ``` But not the lib sources, that requires another package named `google-mock`: ```shell $ dpkg -S /usr/src/gmock google-mock:amd64: /usr/src/gmock ``` But in Ubuntu 16.04 the includes and lib sources are in the `google-mock` package: ```shell $ dpkg -S /usr/include/gmock google-mock:i386: /usr/include/gmock $ dpkg -S /usr/src/gmock/ google-mock:i386: /usr/src/gmock ``` And excitingly, in Ubuntu 20.04 this will again be changed to `libgmock-dev` by the looks of things, just to keep us on our toes.
areusch
pushed a commit
that referenced
this pull request
Sep 27, 2021
Google Mock is the mocking/helper framework that gets bundled with Google Test, it used to be separate but now isn't. I ran into the issue of Google Mock not being configured fully in the i386 build of #9106, which uses the `HasSubtr` matcher. This PR aims to fully configure Google Mock for use, which is interesting in itself... The headers are installed as part of Ubuntu 18.04's `googletest` package: ```shell $ dpkg -S /usr/include/gmock/ googletest:amd64: /usr/include/gmock ``` But not the lib sources, that requires another package named `google-mock`: ```shell $ dpkg -S /usr/src/gmock google-mock:amd64: /usr/src/gmock ``` But in Ubuntu 16.04 the includes and lib sources are in the `google-mock` package: ```shell $ dpkg -S /usr/include/gmock google-mock:i386: /usr/include/gmock $ dpkg -S /usr/src/gmock/ google-mock:i386: /usr/src/gmock ``` And excitingly, in Ubuntu 20.04 this will again be changed to `libgmock-dev` by the looks of things, just to keep us on our toes.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
Google Mock is the mocking/helper framework that gets bundled with Google Test, it used to be separate but now isn't. I ran into the issue of Google Mock not being configured fully in the i386 build of apache#9106, which uses the `HasSubtr` matcher. This PR aims to fully configure Google Mock for use, which is interesting in itself... The headers are installed as part of Ubuntu 18.04's `googletest` package: ```shell $ dpkg -S /usr/include/gmock/ googletest:amd64: /usr/include/gmock ``` But not the lib sources, that requires another package named `google-mock`: ```shell $ dpkg -S /usr/src/gmock google-mock:amd64: /usr/src/gmock ``` But in Ubuntu 16.04 the includes and lib sources are in the `google-mock` package: ```shell $ dpkg -S /usr/include/gmock google-mock:i386: /usr/include/gmock $ dpkg -S /usr/src/gmock/ google-mock:i386: /usr/src/gmock ``` And excitingly, in Ubuntu 20.04 this will again be changed to `libgmock-dev` by the looks of things, just to keep us on our toes.
This was referenced Sep 30, 2021
Mousius
force-pushed
the
interface-api-c++
branch
2 times, most recently
from
eaac78b to
e17f69d
Compare
|
@Mousius lgtm but please address the CI failure |
Mousius
force-pushed
the
interface-api-c++
branch
2 times, most recently
from
2584986 to
6436b27
Compare
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Mousius
force-pushed
the
interface-api-c++
branch
from
6436b27 to
0897a60
Compare
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Google Mock is the mocking/helper framework that gets bundled with Google Test, it used to be separate but now isn't. I ran into the issue of Google Mock not being configured fully in the i386 build of apache#9106, which uses the `HasSubtr` matcher. This PR aims to fully configure Google Mock for use, which is interesting in itself... The headers are installed as part of Ubuntu 18.04's `googletest` package: ```shell $ dpkg -S /usr/include/gmock/ googletest:amd64: /usr/include/gmock ``` But not the lib sources, that requires another package named `google-mock`: ```shell $ dpkg -S /usr/src/gmock google-mock:amd64: /usr/src/gmock ``` But in Ubuntu 16.04 the includes and lib sources are in the `google-mock` package: ```shell $ dpkg -S /usr/include/gmock google-mock:i386: /usr/include/gmock $ dpkg -S /usr/src/gmock/ google-mock:i386: /usr/src/gmock ``` And excitingly, in Ubuntu 20.04 this will again be changed to `libgmock-dev` by the looks of things, just to keep us on our toes.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation. Follow up PRs will clean up any remaining name transformation inconsistencies. Fixes apache#8792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new name transformations added in #9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.
Follow up PRs will clean up any remaining name transformation inconsistencies.
Fixes #8792