[UnitTests] Enable minimum testing on Vulkan target in CI #9093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
a team
as code owners
tmoreau89
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
LGTM, thank you @Lunderberg for enabling Vulkan CI and checking that overheads in CI runtime are contained
- Include the Vulkan runtime in the GPU build. - Run test_target_codegen_vulkan.py as part of the `python3: GPU` CI step.
Lunderberg
force-pushed
the
enable_ci_vulkan
branch
2 times, most recently
from
6f13064
to
0a1ae0b
Compare
The CI builds use the Jenkinsfile located in the ci-docker-staging branch, but the scripts in the PR that is being run. Temporarily adding back a task_config_build_gpu_vulkan.sh, which just calls the renamed task_config_build_gpu_other.sh.
Lunderberg
force-pushed
the
enable_ci_vulkan
branch
from
0a1ae0b
to
3a18e4a
Compare
|
Thank you @Lunderberg @csullivan we finally have Vulkan CI! |
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 29, 2021
* main: Fix flaky NMS test by making sure scores are unique (apache#9140) [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038) [LLVM] Make changes needed for opaque pointers (apache#9138) Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849) [CI] Split Integration tests out of first phase of pipeline (apache#9128) [Meta Schedule][M3b] Runner (apache#9111) Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141) [TIR] add loop partition hint pragma (apache#9121) fix things (apache#9146) [Meta Schedule][M3a] SearchStrategy (apache#9132) [Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133) [UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143) [OpenCL] Remove redundant visit statement in CodeGen. (apache#9144) [BYOC] support arbitrary input dims for add/mul/relu of dnnl c_src codegen (apache#9127) [Relay][ConvertLayout] Support for qnn.conv2d_transpose (apache#9139) add nn.global_avgpool to fq2i (apache#9137) [UnitTests] Enable minimum testing on Vulkan target in CI (apache#9093) [Torch] Support returning quantized weights and bias for BYOC use cases (apache#9135) [Relay] Prepare for new plan_devices.cc (part II) (apache#9130) [microTVM][Zephyr] Add MIMXRT1050 board support (apache#9068)
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [UnitTests] Enable minimum testing on Vulkan target in CI - Include the Vulkan runtime in the GPU build. - Run test_target_codegen_vulkan.py as part of the `python3: GPU` CI step. * [CI] Added a dummy task_config_build_gpu_vulkan.sh, to be removed later. The CI builds use the Jenkinsfile located in the ci-docker-staging branch, but the scripts in the PR that is being run. Temporarily adding back a task_config_build_gpu_vulkan.sh, which just calls the renamed task_config_build_gpu_other.sh.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Oct 7, 2021
Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
masahi
pushed a commit
that referenced
this pull request
Oct 7, 2021
Vulkan unit tests were enabled with #9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
…9219) Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…9219) Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [UnitTests] Enable minimum testing on Vulkan target in CI - Include the Vulkan runtime in the GPU build. - Run test_target_codegen_vulkan.py as part of the `python3: GPU` CI step. * [CI] Added a dummy task_config_build_gpu_vulkan.sh, to be removed later. The CI builds use the Jenkinsfile located in the ci-docker-staging branch, but the scripts in the PR that is being run. Temporarily adding back a task_config_build_gpu_vulkan.sh, which just calls the renamed task_config_build_gpu_other.sh.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…9219) Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enable a minimum testing of the vulkan runtime, without significantly increasing the runtime of the pre-commit CI. The additional tests enabled run in about 3.5 seconds on my local machine, so the CI runtime impact should be minimal.
python3: GPUCI step.