-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] Fix memory leak #2 #8725
Merged
Merged
Commits on Aug 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for db6eb0f - Browse repository at this point
Copy the full SHA db6eb0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a131b7 - Browse repository at this point
Copy the full SHA 3a131b7View commit details -
Rewrite the bindings to fix the ArgValue lifetime issue
There are still quite a few issues left to resolve in this patch, but I believe the runtime changes stablize memory consumption as long as the parameters are only set once. ByteArray also has some totally broken unsafe code which I am unsure of how it was introduced.
Configuration menu - View commit details
-
Copy full SHA for 8226ca3 - Browse repository at this point
Copy the full SHA 8226ca3View commit details -
Finish handling tvm-rt issues due to ArgValue lifetime
This patch further refactors the bindings to better handle the lifetime issues introduced by detecting the argument memory leak.
Configuration menu - View commit details
-
Copy full SHA for 1e4edfe - Browse repository at this point
Copy the full SHA 1e4edfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 109545a - Browse repository at this point
Copy the full SHA 109545aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da8326 - Browse repository at this point
Copy the full SHA 4da8326View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c308e7 - Browse repository at this point
Copy the full SHA 9c308e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb0add - Browse repository at this point
Copy the full SHA dfb0addView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4912a52 - Browse repository at this point
Copy the full SHA 4912a52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53dac41 - Browse repository at this point
Copy the full SHA 53dac41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a3e1e5 - Browse repository at this point
Copy the full SHA 1a3e1e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a90e2f - Browse repository at this point
Copy the full SHA 5a90e2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6ecf60 - Browse repository at this point
Copy the full SHA b6ecf60View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.