[Torch] Remove unused conversion #8397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
changed the title
comaniac
approved these changes
Jul 3, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* fix weight shape in torch.mm conversion * Revert "fix weight shape in torch.mm conversion" This reverts commit a1a8fd3. * [Torch] remove unused conversion
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* fix weight shape in torch.mm conversion * Revert "fix weight shape in torch.mm conversion" This reverts commit a1a8fd3. * [Torch] remove unused conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8392
This could have been a source of accuracy issues. For some reason I don't get shape errors without transpose, only accuracy errors.Actually it turns out this is a dead code...
@comaniac @jcf94 @tqchen