Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Make sure there is no tie in scores in TF combined NMS test #8335

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

masahi
Copy link
Member

@masahi masahi commented Jun 24, 2021

This should remove flaky-ness discussed in #8140.

The flaky output from the workload (1, 64, 20, 4), which uses a different code path than others, seems more frequent. For now I haven't disable it to see if the uniqueness of scores would also fix it. I've run this test 1000 times with this fix and I haven't got an error.

@trevor-m @mbrookhart

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It'll be interesting to see if we still see the boxes failure after this in CI.

Copy link
Contributor

@trevor-m trevor-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masahi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants