[Bug Fix] Fix bug in dense_nopack of x86 when using dynamic input shape #8166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lygztq , can you please add a test case to cover this bug? |
I think there is already a test case for this in relay (see here), but it does not seem to be used in CI. This test will fail on my machine if we do not use cublas for cuda devices and may not invoke this x86 implementation on cpu. And I am not sure whether adding a dynamic shape tensor test here directly is a good choice. |
tqchen
approved these changes
Jun 5, 2021
|
I see, in that case let us merge it for now and add tests later if we have a better idea. Thanks @lygztq ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Kis dynamic, this linek = te.reduce_axis((0, K // vec), "k")cannot work.@jroesch @kevinthesun @tkonolige @tqchen