Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC][Verilator] Skip mobilenet test if Verilator is not available #8094

Merged
merged 3 commits into from
May 21, 2021
Merged

[BYOC][Verilator] Skip mobilenet test if Verilator is not available #8094

merged 3 commits into from
May 21, 2021

Conversation

vegaluisjose
Copy link
Member

@vegaluisjose vegaluisjose mentioned this pull request May 20, 2021
Closed
tmoreau89
tmoreau89 approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. @leandron thank you for flagging the issue.

leandron
leandron reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vegaluisjose, just a small note on the approach to skip the test.

tests/python/contrib/test_verilator/test_mobilenet.py Show resolved Hide resolved
leandron
leandron approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@leandron leandron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - waiting CI, then feel free to merge it.

Thanks @vegaluisjose!

@leandron leandron merged commit 1a51d21 into apache:main May 21, 2021
@leandron
Copy link
Contributor

Merged now. thanks @vegaluisjose @tmoreau89 !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
@vegaluisjose
[BYOC][Verilator] Skip mobilenet test if Verilator is not available (a…
50e9b78 
…pache#8094)

* skip mobilenet test when verilator is not available

* add skipped to pytest

* add pytest
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
@vegaluisjose @trevor-m
[BYOC][Verilator] Skip mobilenet test if Verilator is not available (a…
c38315f 
…pache#8094)

* skip mobilenet test when verilator is not available

* add skipped to pytest

* add pytest
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandron leandron leandron approved these changes

@tmoreau89 tmoreau89 tmoreau89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vegaluisjose @leandron @tmoreau89