[TIR][TRANSFORM] Return value support in tir.tvm_call_packed #7932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the return value support in tir.tvm_call_packed - Clarified the semantics of the intrinsics - Fix a problem when lowering call packed with nested scopes(let bindings) - Added regression tests to cover the changes
giuseros
reviewed
Apr 27, 2021
| @@ -133,11 +133,45 @@ def check_packed_func(target="llvm"): | |||
| tvm.ir.assert_structural_equal(alloca_shape, expected_stmt, map_free_vars=True) | |||
|
|
|||
|
|
|||
| def test_packed_func(): | |||
| def test_lower_packed_func(): | |||
| check_packed_func("llvm") | |||
There was a problem hiding this comment.
Can you add a check also for the C backend? I tried this in AOT (to call _linked_params_lookup) , but the C backend appears to not handling return values correctly.
There was a problem hiding this comment.
i believe previously it was only works for non-C backend, but recent PR might added support
There was a problem hiding this comment.
Is the PR that adds non-LLVM support already merged? If so, I think it should be ok to add a test. If not, we might add a TODO and add the test when the PR gets merged
There was a problem hiding this comment.
I agree a TODO is a good idea
ZihengJiang
approved these changes
Apr 30, 2021
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
…7932) This PR fixes the return value support in tir.tvm_call_packed - Clarified the semantics of the intrinsics - Fix a problem when lowering call packed with nested scopes(let bindings) - Added regression tests to cover the changes
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7932) This PR fixes the return value support in tir.tvm_call_packed - Clarified the semantics of the intrinsics - Fix a problem when lowering call packed with nested scopes(let bindings) - Added regression tests to cover the changes
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7932) This PR fixes the return value support in tir.tvm_call_packed - Clarified the semantics of the intrinsics - Fix a problem when lowering call packed with nested scopes(let bindings) - Added regression tests to cover the changes
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…7932) This PR fixes the return value support in tir.tvm_call_packed - Clarified the semantics of the intrinsics - Fix a problem when lowering call packed with nested scopes(let bindings) - Added regression tests to cover the changes
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…7932) This PR fixes the return value support in tir.tvm_call_packed - Clarified the semantics of the intrinsics - Fix a problem when lowering call packed with nested scopes(let bindings) - Added regression tests to cover the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the return value support in tir.tvm_call_packed