[ONNX] Support optional outputs for ONNX nodes #7818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
reviewed
Apr 9, 2021
| valid_outputs[i] = True | ||
| if not all(valid_outputs): | ||
| tup = op.astuple() | ||
| if isinstance(tup, _expr.Tuple): |
There was a problem hiding this comment.
Does op.astuple not always return an _expr.Tuple?
There was a problem hiding this comment.
No, we use TupleWrapper for other nodes, like call nodes with multiple outputs, see split:
tvm/python/tvm/relay/op/transform.py
Line 861 in 461d06e
jwfromm
approved these changes
Apr 9, 2021
|
LGTM, i think a few comments explaining the logic here would be helpful though. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Support optional outputs for ONNX nodes * add comments
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Support optional outputs for ONNX nodes * add comments
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Support optional outputs for ONNX nodes * add comments
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* Support optional outputs for ONNX nodes * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enables some cast tests that were incorrectly skipped.