Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARITH] normalize iter affine map expr to PrimExpr #7759

Merged
merged 7 commits into from
Mar 29, 2021
Merged

[ARITH] normalize iter affine map expr to PrimExpr #7759

merged 7 commits into from
Mar 29, 2021

Conversation

spectrometerHBH
Copy link
Contributor

cc @tqchen

@tqchen tqchen added the status: need test case need test cases to cover the change label Mar 27, 2021
@tqchen
Copy link
Member

tqchen commented Mar 27, 2021

Thanks @spectrometerHBH can you add a few testcases for normalize_iter_map_to_expr? Thank you!

@tqchen
Copy link
Member

tqchen commented Mar 27, 2021

cc @hzfan @Hzfengsy @jinhongyii

@tqchen tqchen self-assigned this Mar 27, 2021
@spectrometerHBH
Copy link
Contributor Author

The CI error looks wired to me. I don't know what leads to the error

Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

src/arith/iter_affine_map.cc Show resolved Hide resolved
src/arith/iter_affine_map.cc Outdated Show resolved Hide resolved
@tqchen tqchen added status: accepted and removed status: need review status: need test case need test cases to cover the change labels Mar 29, 2021
@tqchen tqchen merged commit af6f167 into apache:main Mar 29, 2021
@tqchen
Copy link
Member

tqchen commented Mar 29, 2021

@junrushao junrushao linked an issue Mar 29, 2021 that may be closed by this pull request
29 tasks
@spectrometerHBH spectrometerHBH deleted the iter-affine-map-convert branch March 30, 2021 00:26
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants