[TVMC] Allow optional arguments to be passed to importers #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leandron @jwfromm @mdw-octoml Could you take a look at this PR? |
comaniac
approved these changes
Mar 16, 2021
mdw-octoml
reviewed
Mar 16, 2021
|
|
||
| mod, params = tvmc.frontends.load_model(onnx_resnet50) | ||
| def verify_load_model__onnx(model, **kwargs): |
There was a problem hiding this comment.
As in the comment above, I would probably suggest using @pytest.mark.parametrize here as well and not having the separate verify_load_model__onnx helper function.
There was a problem hiding this comment.
The onnx test is a little bit more complex because of the things being tested, so I think I'm going to leave it as is and try to not break things.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* add support for optional args for frontends tvmc * remove unnecessary comments * Add changes suggested by Matt W. via PR Co-authored-by: Jocelyn <jocelyn@pop-os.localdomain>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* add support for optional args for frontends tvmc * remove unnecessary comments * Add changes suggested by Matt W. via PR Co-authored-by: Jocelyn <jocelyn@pop-os.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to pass optional arguments to importers within TVMC. For example, onnx importers have a "freeze_params" argument that is useful for supporting certain models.
This change is aimed at making TVMC more useful when called from python, but doesn't impact the command line experience.