Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMC] Allow options on --target to contain dots. #7651

Merged
merged 1 commit into from
Mar 12, 2021
Merged

[TVMC] Allow options on --target to contain dots. #7651

merged 1 commit into from
Mar 12, 2021

Conversation

leandron
Copy link
Contributor

@leandron leandron commented Mar 12, 2021 •
edited
Loading

Allow options on --target to contain dots.

  • Allow tvmc compile --target=*** options to accept dots
  • Adds testing for dot separator in quoted and unquoted values
  • Add an "unquoting" conditional so that quoted and unquoted strings look the same when parsed

cc @u99127 @comaniac @giuseros for reviews when possible.

@leandron
[TVMC] Allow options on --target to contain dots.
a267008 
 * Allow tvmc compile --target options to accept dots
 * Adds testing for dot separator in quoted and unquoted
   values
 * Add an "unquoting" conditional so that quoted and
   unquoted strings look the same when parsed
giuseros
giuseros reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@giuseros giuseros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @leandron ! I only have a minor comment, then it LGTM

python/tvm/driver/tvmc/common.py Show resolved Hide resolved
comaniac
comaniac reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

tests/python/driver/tvmc/test_tvmc_common.py Show resolved Hide resolved
python/tvm/driver/tvmc/common.py Show resolved Hide resolved
@comaniac comaniac merged commit fe25b9e into apache:main Mar 12, 2021
@comaniac
Copy link
Contributor

Thanks @leandron @giuseros.
The follow-up PR will improve the readability and unit tests of target matching regex.

@leandron leandron mentioned this pull request Mar 12, 2021
Merged
@leandron leandron deleted the fix_tvmc_target_parser branch March 12, 2021 19:05
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@leandron
[TVMC] Allow options on --target to contain dots. (apache#7651)
f727574 
* Allow tvmc compile --target options to accept dots
 * Adds testing for dot separator in quoted and unquoted
   values
 * Add an "unquoting" conditional so that quoted and
   unquoted strings look the same when parsed
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@leandron @trevor-m
[TVMC] Allow options on --target to contain dots. (apache#7651)
186a449 
* Allow tvmc compile --target options to accept dots
 * Adds testing for dot separator in quoted and unquoted
   values
 * Add an "unquoting" conditional so that quoted and
   unquoted strings look the same when parsed
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseros giuseros giuseros left review comments

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leandron @comaniac @giuseros