Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] Fix converting torch slice op with dynamic slice length #7549

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

masahi
Copy link
Member

@masahi masahi commented Mar 1, 2021

Fixes #7546

This is an easy PR to fix the bug introduced in #7479. Thanks @apivovarov for reporting.

Please review @kevinthesun @comaniac @siju-samuel @apivovarov

@masahi
Copy link
Member Author

masahi commented Mar 2, 2021

ping @kevinthesun @comaniac @siju-samuel this is ready to go, @apivovarov needs this fix

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 08ea961 into apache:main Mar 2, 2021
@comaniac
Copy link
Contributor

comaniac commented Mar 2, 2021

Thanks @masahi @apivovarov

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…he#7549)

* Fix converting torch slice op with dynamic slice length

* use isinstance

Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
…he#7549)

* Fix converting torch slice op with dynamic slice length

* use isinstance

Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[torch] slice with Var Length fails
3 participants