[Target] Add support for target object with host field compatible with previous api #7534

zxybazh · 2021-02-26T01:28:33Z

This PR is to support the new target obejct with host field in TVM, migrating functions to support both version. Future deprecation of old target host api is pending dicussion in the RFC channel. Fixed the problem of adding existing target host to its target.

zxybazh · 2021-02-26T01:31:51Z

This is the python script part and a lot of testcases could be added.

tests/python/unittest/test_target_target.py

junrushao · 2021-02-26T20:20:06Z

Let's also note the potential influence that this change can affect the target string used in AutoTVM/Ansor and avoid introducing any regression.

junrushao · 2021-03-17T17:22:31Z

@zxybazh would you like to fix the CI issue? Thanks a lot!

junrushao

Thanks for the improvement! Please find my review below

include/tvm/target/target.h

junrushao · 2021-03-18T05:44:08Z

include/tvm/target/target.h

+TVM_DLL void RefreshHost(Target*, Target*);
+TVM_DLL void RefreshHost(TargetsMap*, Target*);
+TVM_DLL void RefreshHost(Map<Target, IRModule>*, Target*);


Functions in the header file needs clear documentation. More specifically, we need to document very clearly that those functions are not encouraged for common use :-)

Please list the names of arguments.

Also, please consider a name for the function better indicating they are dedicated to legacy behavior. What about Target::SplitIntoLegacyTargetPair?

Consider moving those functions into static functions of the Target class

I found that I cannot move the part of the helper function into the Target class because it requires a Map<Target, ObjectRef> type which cannot be compiled correctly. Therefore, I would put the functions outside the class for now.

python/tvm/autotvm/measure/measure_methods.py

python/tvm/autotvm/task/relay_integration.py

python/tvm/relay/backend/vm.py

python/tvm/target/target.py

src/auto_scheduler/measure_record.cc

src/target/target.cc

junrushao

LGTM! Thanks @zxybazh for the contribution!

…h previous api (apache#7534) * Fix legacy code on target host * Modify legacy code for target host change * Add tests and fix merge issue * Add condition for same host * Modify all files for new target host api compatibility * Add newline * Change import format * Optimize test file * Add match error info for unit tests * Fix for heterogeneous targets * Fix format for dict iteration * Fix target host type error * Skip one testcase for tvm infinite loop bug * Fixed bug for target map compatibility * Fix another TargetsMap issue * Fix typo and infinite loop error * Temporary fix for handle issue * Fix vm target * Add condition support for str case * Add GetHost function and fix previous bugs * Fix measure_record.cc * Fix search_task.cc * Fix compiler.cc, memory_alloc.cc * Fix driver_api.cc * Fix format * Fix bugs and GetHost function usage * Fix clang format * Fix bug * Modify python tests * Change python unit tests to new target api * Fi test_runtime_heterogeneous.py * Modify tutorials & remove extra print * Update more tests to new api * Refine the tutorial target usage * change argument name for Target constructor function * Fix target export function * Fix and validate all tutorial usage * Remove unused argument * Fix format * Fix bug in driver/build_module.py for heterogeneous target * Fix bug in driver/build_module.py for heterogeneous target more * Fix target host type error * Fix cudnn target host bug * Fix according to reviews, add helper function in python * Refactor code as helper function * Expand helper function * Fix bug add and update python helper function * Update target hosts * Fix format & refresh function * Fix unit test bug * Fix bug in refreshing host * Fix bug * Add SetHost function * Update export function * Fix format * Fix export bug in target * Fix bug on host referencing * Addtional tests * Address review issues * Fix format target.py * Fix issues and format * Add some 3rd party dependencies * Merge main branch * Fix target.h format * Remove redundent import * Fix function name * Add parameter name * Fix new code bug * Fix bug in lowering

zxybazh added 5 commits February 24, 2021 19:27

Fix legacy code on target host

6401b6f

Modify legacy code for target host change

0167a5f

Add tests and fix merge issue

2a3c502

Add condition for same host

511ce56

Modify all files for new target host api compatibility

69601a7

zxybazh added 2 commits February 25, 2021 23:05

Add newline

23187d8

Change import format

85b27db

areusch reviewed Feb 26, 2021

View reviewed changes

tests/python/unittest/test_target_target.py Outdated Show resolved Hide resolved

tests/python/unittest/test_target_target.py Show resolved Hide resolved

zxybazh added 2 commits February 26, 2021 10:17

Optimize test file

7e4eb0a

Add match error info for unit tests

59457f6

zxybazh added 18 commits March 1, 2021 16:22

Fix for heterogeneous targets

b7e4c71

Fix format for dict iteration

f5ccc50

Fix target host type error

11c77ba

Merge branch 'main' of https://github.com/zxybazh/tvm into target

ca95bfd

Skip one testcase for tvm infinite loop bug

7543422

Fixed bug for target map compatibility

fbd597a

Fix another TargetsMap issue

4d11b7b

Fix typo and infinite loop error

5a0f06b

Temporary fix for handle issue

0e01e13

Fix vm target

7db8327

Add condition support for str case

f214410

Add GetHost function and fix previous bugs

38c4ec0

Fix measure_record.cc

8bacc8d

Fix search_task.cc

36153dd

Fix compiler.cc, memory_alloc.cc

df1f6a1

Fix driver_api.cc

4539cff

Fix format

b328525

Fix bugs and GetHost function usage

ba427ec

zxybazh added 2 commits March 17, 2021 10:45

Fix bug on host referencing

4442fba

Addtional tests

542c927

junrushao reviewed Mar 18, 2021

View reviewed changes

zxybazh added 5 commits March 18, 2021 14:17

Address review issues

8a537b4

Fix format target.py

6f76c1d

Fix issues and format

f46626f

Add some 3rd party dependencies

244cc40

Merge main branch

fdfb93a

zxybazh requested a review from yzhliu as a code owner March 30, 2021 02:13

zxybazh force-pushed the target branch from e2b5c1a to fdfb93a Compare March 30, 2021 02:38

zxybazh added 8 commits March 29, 2021 21:11

Merge branch 'main' into target

7f509bd

Fix target.h format

3804269

Remove redundent import

dd3787c

Fix function name

6e114ca

Add parameter name

adec87f

Merge branch 'main' into target

34f1dac

Fix new code bug

b71bd1a

Fix bug in lowering

3a8080e

junrushao reviewed Mar 31, 2021

View reviewed changes

junrushao approved these changes Mar 31, 2021

View reviewed changes

junrushao merged commit 0bd1536 into apache:main Mar 31, 2021

huochaitiantang mentioned this pull request Apr 2, 2021

target = None error while tuing an autotvm task #7790

Closed

zxybazh deleted the target branch April 26, 2021 21:20

junrushao mentioned this pull request Nov 1, 2021

Apache TVM v0.8 Release Note Candidate #9416

Closed

gromero mentioned this pull request Apr 11, 2022

[AutoTVM] Use new target object #10963

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Target] Add support for target object with host field compatible with previous api #7534

[Target] Add support for target object with host field compatible with previous api #7534

zxybazh commented Feb 26, 2021

zxybazh commented Feb 26, 2021

junrushao commented Feb 26, 2021

junrushao commented Mar 17, 2021

junrushao left a comment

junrushao Mar 18, 2021

zxybazh Mar 30, 2021

junrushao left a comment

[Target] Add support for target object with host field compatible with previous api #7534

[Target] Add support for target object with host field compatible with previous api #7534

Conversation

zxybazh commented Feb 26, 2021

zxybazh commented Feb 26, 2021

junrushao commented Feb 26, 2021

junrushao commented Mar 17, 2021

junrushao left a comment

Choose a reason for hiding this comment

junrushao Mar 18, 2021

Choose a reason for hiding this comment

zxybazh Mar 30, 2021

Choose a reason for hiding this comment

junrushao left a comment

Choose a reason for hiding this comment