-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] Make TVM Rust bindings installable via Cargo. #7503
Conversation
@jroesch please fix the lint error(adding ASF header comments to the markdown files) |
This PR is great. Thank you! |
It would be really great to get this merged, if possible. |
@schell sorry I got really busy with some parallel work at OctoML and I didn't realize anyone was blocked on this, will try and land over the weekend! sorry for the latency here the Rust bindings traditionally haven't seen as much use as I would like and can become lower priority. |
No worries @jroesch, thank you! |
@jroesch can you take a look at the CI? Hopefully this is close, I just want to keep it on your radar. |
@jwfromm As part of updating the Rust code we need some new dependencies in the CI containers just waiting for them to land in master and we can trigger a build, there was unfortunately a series of different changes which interacted poorly in CI leading to this breaking on this branch. |
f659212
to
b6f98c0
Compare
Disabled a few things so this can land in parallel with my CI updates which might take a little longer to an underlying issue with GPU configuration (nothing to do with these changes but prevents updating the Docker image). |
faa290a
to
c288273
Compare
Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. Fixes for version bump Update build.rs to use new tvm-build version Tweak build.rs to use release version of tvm-build Add docs Add Readme for tvm-sys crate. Fix Cargo verisions for pre-release Add README Move generated code to OUT_DIR Fix path Add descp for tvm-sys Tweak versions for publishing Tweak versions for publishing Add README for tvm-graph-rt Conform to Apache branding guidelines Fix caps Add header Remove warning Format Clean up build Turn docs back on Tweak CI WIP Remove CI changes
@@ -17,7 +17,7 @@ | |||
|
|||
[package] | |||
name = "tvm-graph-rt" | |||
version = "0.1.0" | |||
version = "0.1.0-alpha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come you bumped to -alpha but didn't increment any other number?
@@ -17,7 +17,7 @@ | |||
|
|||
[package] | |||
name = "tvm-rt" | |||
version = "0.1.0" | |||
version = "0.1.0-alpha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question
@@ -36,7 +36,7 @@ blas = ["ndarray/blas"] | |||
python = ["pyo3"] | |||
|
|||
[dependencies.tvm-rt] | |||
version = "0.1" | |||
version = "0.1.0-alpha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question
@areusch The packages of previously released packages had to be bumped to 1.1 while previous packages were at 1.0. We can unify the version numbering when we officially release them. I need to turn CI back on next before we can fix version numbers and issue a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sounds good, we can re-evaluate when CI is switched back on
🎉 |
* Make TVM Cargo installable Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. Fixes for version bump Update build.rs to use new tvm-build version Tweak build.rs to use release version of tvm-build Add docs Add Readme for tvm-sys crate. Fix Cargo verisions for pre-release Add README Move generated code to OUT_DIR Fix path Add descp for tvm-sys Tweak versions for publishing Tweak versions for publishing Add README for tvm-graph-rt Conform to Apache branding guidelines Fix caps Add header Remove warning Format Clean up build Turn docs back on Tweak CI WIP Remove CI changes * Disable docs * Fix
* Make TVM Cargo installable Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. Fixes for version bump Update build.rs to use new tvm-build version Tweak build.rs to use release version of tvm-build Add docs Add Readme for tvm-sys crate. Fix Cargo verisions for pre-release Add README Move generated code to OUT_DIR Fix path Add descp for tvm-sys Tweak versions for publishing Tweak versions for publishing Add README for tvm-graph-rt Conform to Apache branding guidelines Fix caps Add header Remove warning Format Clean up build Turn docs back on Tweak CI WIP Remove CI changes * Disable docs * Fix
* Make TVM Cargo installable Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. Fixes for version bump Update build.rs to use new tvm-build version Tweak build.rs to use release version of tvm-build Add docs Add Readme for tvm-sys crate. Fix Cargo verisions for pre-release Add README Move generated code to OUT_DIR Fix path Add descp for tvm-sys Tweak versions for publishing Tweak versions for publishing Add README for tvm-graph-rt Conform to Apache branding guidelines Fix caps Add header Remove warning Format Clean up build Turn docs back on Tweak CI WIP Remove CI changes * Disable docs * Fix
* Make TVM Cargo installable Rewrite the Rust Module API and change some imports causing crashes. This commit also updates the docs to remove outdated information. Fixes for version bump Update build.rs to use new tvm-build version Tweak build.rs to use release version of tvm-build Add docs Add Readme for tvm-sys crate. Fix Cargo verisions for pre-release Add README Move generated code to OUT_DIR Fix path Add descp for tvm-sys Tweak versions for publishing Tweak versions for publishing Add README for tvm-graph-rt Conform to Apache branding guidelines Fix caps Add header Remove warning Format Clean up build Turn docs back on Tweak CI WIP Remove CI changes * Disable docs * Fix
This builds on #7085 and is blocked on that merging. This PR makes it possible for us to release crates which can complete the entire TVM installation without needing users to build TVM.