Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][TRT] Fix weight conversion when first dim of weight shape is 1 #7253

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

trevor-m
Copy link
Contributor

Fixes conversion of weight shape to work with TensorRT's implicit batch dimension.
Added test cases which failed before this change.
Before this PR, a conv2d or dense op which has a kernel weight beginning with 1 ([1, 32, 3, 3] or [1, 128] for example) would cause an error.

Also, there is an unrelated change to add conv2d_transpose to ConvertLayout list in partition_for_tensorrt.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trevor-m
Copy link
Contributor Author

LGTM

@comaniac Thanks for the review!

@comaniac comaniac merged commit ac684f9 into apache:main Jan 12, 2021
@comaniac
Copy link
Contributor

Thanks @trevor-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants