Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add op_name in error message for Pool #7243

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

luyaor
Copy link
Contributor

@luyaor luyaor commented Jan 11, 2021

Previous version will not raise correct error since the op_name is not defined.
@jwfromm

@jwfromm
Copy link
Contributor

jwfromm commented Jan 12, 2021

More info in error messages is always good. LGTM

@luyaor
Copy link
Contributor Author

luyaor commented Jan 12, 2021

@jwfromm Hi, could you help to merge this PR? Or anyone else is needed for approving review?

@ZihengJiang
Copy link
Contributor

Merged. Thanks @luyaor @jwfromm

@ZihengJiang ZihengJiang merged commit 4364386 into apache:main Jan 12, 2021
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
* add op_name in error message for Pool

* fix tiny issue for arguments

* fix tiny issue for LpPool

Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 18, 2021
* add op_name in error message for Pool

* fix tiny issue for arguments

* fix tiny issue for LpPool

Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
* add op_name in error message for Pool

* fix tiny issue for arguments

* fix tiny issue for LpPool

Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
* add op_name in error message for Pool

* fix tiny issue for arguments

* fix tiny issue for LpPool

Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
* add op_name in error message for Pool

* fix tiny issue for arguments

* fix tiny issue for LpPool

Co-authored-by: luyaor <luyaor@luyaordeMacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants