Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend][ONNX] Allow condition in if op to be an array. #7215

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

jwfromm
Copy link
Contributor

@jwfromm jwfromm commented Jan 5, 2021

This PR is a very small addition to our if converter that unpacks an input condition for an If operator into a scalar if it's passed as an array, which the onnx spec allows.

@jwfromm
Copy link
Contributor Author

jwfromm commented Jan 5, 2021

@mbrookhart @tmoreau89 can you take a look at this PR?

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwfromm for the fix, LGTM

@tmoreau89 tmoreau89 merged commit 197594b into apache:main Jan 5, 2021
@tmoreau89
Copy link
Contributor

Thanks everyone, the PR has been merged.

tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this pull request Jan 11, 2021
masahi pushed a commit to masahi/tvm that referenced this pull request Jan 14, 2021
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
@jwfromm jwfromm deleted the onnx_if_array branch April 12, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants