TF frontend: add rint op #6818
Merged
TF frontend: add rint op #6818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
reviewed
Nov 3, 2020
| @@ -2391,6 +2391,7 @@ def _impl(inputs, attr, params, mod): | |||
| "ReverseV2": _reverse_v2(), | |||
| "RightShift": AttrCvt("right_shift"), | |||
| "Round": AttrCvt("round"), | |||
| "Rint": AttrCvt("round"), | |||
There was a problem hiding this comment.
preserve the alphabetical order. keep Rint above Round.
siju-samuel
reviewed
Nov 3, 2020
|
|
||
| def _test_forward_rint(shape): | ||
| tf.disable_eager_execution() | ||
| np_data = np.random.uniform(1, 100, size=shape).astype(np.float32) |
There was a problem hiding this comment.
include -ve floats also for testing.
There was a problem hiding this comment.
Thank you for your comments, but I don't get your point.
What does '- ve floats' mean?
There was a problem hiding this comment.
use
np_data = np.random.uniform(-100, 100, size=shape).astype(np.float32)
|
Hi @alter-xp , |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* TF frontend: add rint op * Added negative numbers to the test
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* TF frontend: add rint op * Added negative numbers to the test
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* TF frontend: add rint op * Added negative numbers to the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enrich the support of TF operator and the need of practical work, we add rint op in tensorflow frontend.
@giuseros