Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Minor fix for some TF OD models #6729

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Conversation

kevinthesun
Copy link
Contributor

return tvm::tir::Select(condition(condition_idx) != 0, x(), y());
PrimExpr cond;
if (condition->shape.size() == 0) {
cond = condition();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, does cond != 0 alway hold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. cond is a scalar.

"""
cond_shape = inputs[0]
x_shape = inputs[1]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be just one-liner

out_shape = x_shape if x_shape.shape else cond_shape

@zhiics zhiics merged commit b9df4a7 into apache:main Oct 23, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Oct 23, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
masahi pushed a commit to masahi/tvm that referenced this pull request Oct 23, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Oct 29, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
codeislife99 pushed a commit to codeislife99/incubator-tvm that referenced this pull request Nov 20, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 31, 2021
* Minor fix for some tf od models

* More fix

* Minor fix

* Fix lint

* Minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants