-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] Change some passes to mix mode #6695
Conversation
3da9dd1
to
7c3e75e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick on constant folding, but it's definitely not an issue. Overall, looks great! Thanks for doing this!
@@ -118,7 +120,7 @@ class ConstantFolder : public ExprMutator { | |||
} | |||
} | |||
|
|||
Expr VisitExpr_(const CallNode* call) final { | |||
Expr Rewrite_(const CallNode* call, const Expr& post) final { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) You could locally rename this argument from post to res, and then you wouldn't need most of the other changes in the function?
@mbrookhart Could you please take a look?