Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Simplify reduce expression in te.gradient #6611

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

yzhliu
Copy link
Member

@yzhliu yzhliu commented Oct 1, 2020

Update the pointer with simplified reduction for later use.
The bug doesn't affect functionality but does harm to performance.

@ArmageddonKnight @comaniac
better to be included in the release. @zhiics @ZihengJiang

@ArmageddonKnight
Copy link
Contributor

FYI, I have tested on the dense and batch norm layer and the AD pass works as expected.

@ZihengJiang
Copy link
Contributor

@yzhliu Added into the release note. Let's merge it after CI passed

@comaniac comaniac merged commit 1ff5f39 into apache:master Oct 2, 2020
@comaniac
Copy link
Contributor

comaniac commented Oct 2, 2020

Thanks @yzhliu

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants