[BYOC][ETHOSN] Fix tests for new module API #6560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8
Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796
comaniac
reviewed
Sep 25, 2020
There was a problem hiding this comment.
The changes look fine to me overall. However, I cannot verify the correctness of most changes due to the lack of test environment.
@u99127 @manupa-arm it would be great if you could review and approve explicitly.
|
cc @Leo-arm could you take a look? |
manupak
reviewed
Sep 28, 2020
Leo-arm
approved these changes
Sep 28, 2020
Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae
manupak
approved these changes
Sep 29, 2020
|
LGTM |
comaniac
approved these changes
Sep 30, 2020
|
Thanks @mbaret @manupa-arm @Leo-arm |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again.