Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG. #6429

Merged
merged 4 commits into from
Sep 24, 2020
Merged

[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG. #6429

merged 4 commits into from
Sep 24, 2020

Conversation

jainris
Copy link
Contributor

@jainris jainris commented Sep 9, 2020

This is a follow-up PR of #6303.

  • Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
    (Similar to MATRIX_SET_DIAG V3 of TF)
  • Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.

@jainris
Copy link
Contributor Author

jainris commented Sep 9, 2020

cc @siju-samuel @mbaret @anijain2305 @u99127 @FrozenGene @tqchen

u99127
u99127 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@u99127 u99127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Might need to run it through black for the python bits .

Ramana

@zhiics
Copy link
Member

zhiics commented Sep 18, 2020

@siju-samuel @mbaret @anijain2305 @FrozenGene please help review. Thanks.

Rishabh Jain added 2 commits September 21, 2020 12:22
[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET…
997e0a2 
…_DIAG.

* Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
  (Similar to MATRIX_SET_DIAG V3 of TF)
* Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
Changes by black.
8bff88c
mbaret
mbaret requested changes Sep 23, 2020
View reviewed changes
include/tvm/topi/transform.h Outdated Show resolved Hide resolved
src/relay/op/tensor/transform.cc Show resolved Hide resolved
@mbaret
Copy link
Contributor

mbaret commented Sep 23, 2020

ping @siju-samuel could you take a look at this as I believe you requested this functionality?

siju-samuel
siju-samuel reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@siju-samuel siju-samuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small suggestions

python/tvm/relay/op/transform.py Outdated Show resolved Hide resolved
tests/python/relay/test_op_level10.py Show resolved Hide resolved
anijain2305
anijain2305 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After samuel's comments are addressed, I can merge

python/tvm/topi/transform.py Outdated Show resolved Hide resolved
mbaret
mbaret approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jainris
Copy link
Contributor Author

jainris commented Sep 24, 2020

@anijain2305 I believe this is ready to be merged.

@anijain2305 anijain2305 merged commit 39c4719 into apache:master Sep 24, 2020
@anijain2305
Copy link
Contributor

Thanks @jainris @mbaret @siju-samuel @u99127 This is merged!

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
@jainris
[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET…
5b99e0b 
…_DIAG. (apache#6429)

* [Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG.

* Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
  (Similar to MATRIX_SET_DIAG V3 of TF)
* Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.

* Changes by black.

* * Added offset check in Relay.
* Minor changes.

* Added more tests and some minor documentation changes.
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
@jainris
[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET…
dedc9e5 
…_DIAG. (apache#6429)

* [Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG.

* Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
  (Similar to MATRIX_SET_DIAG V3 of TF)
* Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.

* Changes by black.

* * Added offset check in Relay.
* Minor changes.

* Added more tests and some minor documentation changes.
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
@jainris
[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET…
7f03133 
…_DIAG. (apache#6429)

* [Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG.

* Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
  (Similar to MATRIX_SET_DIAG V3 of TF)
* Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.

* Changes by black.

* * Added offset check in Relay.
* Minor changes.

* Added more tests and some minor documentation changes.
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
@jainris
[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET…
488926f 
…_DIAG. (apache#6429)

* [Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG.

* Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
  (Similar to MATRIX_SET_DIAG V3 of TF)
* Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.

* Changes by black.

* * Added offset check in Relay.
* Minor changes.

* Added more tests and some minor documentation changes.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
@jainris @trevor-m
[Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET…
e5eac94 
…_DIAG. (apache#6429)

* [Relay/TOPI] Added 'offsets' and 'alignment' attributes to MATRIX_SET_DIAG.

* Added support for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.
  (Similar to MATRIX_SET_DIAG V3 of TF)
* Added tests for 'offsets' and 'alignment' attributes of MATRIX_SET_DIAG.

* Changes by black.

* * Added offset check in Relay.
* Minor changes.

* Added more tests and some minor documentation changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siju-samuel siju-samuel siju-samuel left review comments

@anijain2305 anijain2305 anijain2305 approved these changes

@u99127 u99127 u99127 approved these changes

@mbaret mbaret mbaret approved these changes

Assignees

@anijain2305 anijain2305

Labels
status: need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jainris @zhiics @mbaret @anijain2305 @siju-samuel @u99127 @ZihengJiang