[RELAY] Fix the FoldConstant Regression for VTA #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
approved these changes
Sep 2, 2020
|
For reference here's the PR that introduced the regression. The regression was not caught because the of a buggy CI that did not catch the regression, until recently when Tianqi fixed the CI script. |
anijain2305
approved these changes
Sep 2, 2020
|
Thanks @tqchen for the fix. Thanks @tmoreau89 for raising this. The fix ensures that the compilation time improvement is retained from the origin PR #6195 |
This PR fixes an error guard during the documentation build step. - Temporary disables VTA frontend tutorial due to the regression of deploy_detection
jroesch
reviewed
Sep 2, 2020
| @@ -230,7 +216,17 @@ class ConstantFolder : public ExprMutator { | |||
| auto entry_func = Downcast<Function>(mod->Lookup("main")); | |||
| expr = expr.as<FunctionNode>() == nullptr ? entry_func->body : entry_func; | |||
|
|
|||
| FInterpreter executor = GetInterpreter(mod); | |||
| using tvm::transform::PassContext; | |||
There was a problem hiding this comment.
We will need the make sure the context is set during the executor(input) call besides the creation.
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* [RELAY] Fix the FoldConstant Regression for VTA * [CI] Fix error guard that was missed in VTA. This PR fixes an error guard during the documentation build step. - Temporary disables VTA frontend tutorial due to the regression of deploy_detection
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* [RELAY] Fix the FoldConstant Regression for VTA * [CI] Fix error guard that was missed in VTA. This PR fixes an error guard during the documentation build step. - Temporary disables VTA frontend tutorial due to the regression of deploy_detection
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* [RELAY] Fix the FoldConstant Regression for VTA * [CI] Fix error guard that was missed in VTA. This PR fixes an error guard during the documentation build step. - Temporary disables VTA frontend tutorial due to the regression of deploy_detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tmoreau89 @anijain2305