Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler #6297

Merged
merged 11 commits into from
Sep 9, 2020

Conversation

minminsun
Copy link
Contributor

For full upstream plan, see Ansor RFC.

In this PR, we enable AutoScheduler to rewrite the layout of placeholders to best fit the loop nest of the candidate schedule to be applied on ComputeDAG.

Note that the function in this PR is only for performance evaluation with layout rewrite. An end-to-end solution of layout rewrite requires close cooperation with relay passes, which will be provided in future PRs.

CC @merrymercy @jcf94 @FrozenGene @comaniac @tqchen

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important point in this PR to me is lacking of comments to explain what the code is doing. Also please add unit tests.

include/tvm/auto_scheduler/transform_step.h Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented Sep 3, 2020

cc @jwfromm @mbrookhart @yzhliu

python/tvm/auto_scheduler/compute_dag.py Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
python/tvm/auto_scheduler/compute_dag.py Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
src/auto_scheduler/compute_dag.cc Outdated Show resolved Hide resolved
@merrymercy
Copy link
Member

merrymercy commented Sep 9, 2020

@minminsun Please fix some final style comments and we can merge this

@minminsun
Copy link
Contributor Author

@minminsun Please fix some final style comments and we can merge this

Done.

@merrymercy merrymercy merged commit 8499d58 into apache:master Sep 9, 2020
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
…e#6297)

* enable layout rewrite for auto scheduler

* refine

* update

* fix CI

* fix CI

* fix CI

* resolve review comments

* add ut

* resolve comments

* resolve comments

* fix coding style
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
…e#6297)

* enable layout rewrite for auto scheduler

* refine

* update

* fix CI

* fix CI

* fix CI

* resolve review comments

* add ut

* resolve comments

* resolve comments

* fix coding style
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
…e#6297)

* enable layout rewrite for auto scheduler

* refine

* update

* fix CI

* fix CI

* fix CI

* resolve review comments

* add ut

* resolve comments

* resolve comments

* fix coding style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants