[REFACTOR][RELAY] Move invoke_tvm_op and shape_func to vm dialect #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
force-pushed
the
vm_dialect
branch
2 times, most recently
from
8713f6f
to
f1f02e2
Compare
|
Why change dialects? all of this machinery is probably needed for future work people want to do such as ahead of time compilation. cc @tqchen |
|
@jroesch aah, I am just separating them into memory and vm namespaces. For example, |
|
I think the separation makes sense if we agreed on the categorization. The common one should go to the memory dialect and the vm specific ones should goes into vm. @jroesch can you followup? |
zhiics
force-pushed
the
vm_dialect
branch
2 times, most recently
from
cbb6821
to
8d8f5ed
Compare
|
@jroesch Could you take a look again? |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
…ache#5958) * [REFACTOR][RELAY] Move invoke_tvm_op and shape_func to vm dialect * address comments
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
…ache#5958) * [REFACTOR][RELAY] Move invoke_tvm_op and shape_func to vm dialect * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves invoke_tvm_op and shape_func from memory dialect to vm dialect.
@icemelon9 @jroesch @wweic