[topi][relay] add operation tan to TVM #4938
Conversation
|
Minor comments. Also can you rebase master? |
|
@kevinthesun Hi ! Thanks! In order to fix failed test (precision error), I am trying to update the I can rebase now, but I guess test will fail again. |
notoraptor
force-pushed
the
relay-op-tan
branch
from
ec279af
to
b689301
Compare
|
Rebased and updated to try to fix failing test. |
notoraptor
force-pushed
the
relay-op-tan
branch
from
24cb0c2
to
2a9efd9
Compare
|
Hi @kevinthesun I rebased and added shape function for tan in latest commit. I still have a mismatch error in |
notoraptor
force-pushed
the
relay-op-tan
branch
3 times, most recently
from
2623c57
to
138b3e7
Compare
This reverts commit 4da5b50.
Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.
|
@kevinthesun Tests passed ! I implemented tan in LLVM using |
|
@notoraptor Thanks! |
|
NOTE: the git commit message messed up today due to github issue https://discuss.tvm.ai/t/github-issue-the-commit-author-is-wrong-since-today/5880/15 we should refrain from merging others' PR until tomorrow |
|
@tqchen Do we need to do something for this PR? |
|
This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The community has decided to use revert/redo approach to amend the contributions as per #5015 |
|
Hi @tqchen ! OK for that. Anyway, if it causes some problems, then we can just let things as it is, as my main goal was just to make Thanks ! |
|
cc @kevinthesun please send the reverting PR, then @notoraptor can send the patch |
This reverts commit d992468.
* Add relay operation relay.op.tan. * Update tan implementation in TVM. * Update tests. * Add shape function for tan. * Add missing main test to python/frontend/tensorflow/test_forward. * Revert, back to sin/cos. * Revert "Revert, back to sin/cos." This reverts commit 4da5b50. * Fix implementation of tan in cuda. Do not support tan for float16. Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.
* Add relay operation relay.op.tan. * Update tan implementation in TVM. * Update tests. * Add shape function for tan. * Add missing main test to python/frontend/tensorflow/test_forward. * Revert, back to sin/cos. * Revert "Revert, back to sin/cos." This reverts commit 4da5b50. * Fix implementation of tan in cuda. Do not support tan for float16. Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.
Hi! This pull request adds operation tan to TVM. The main goal is to make it available in relay module.