Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty CSourceModule when no lowered_funcs exists in Relay mod #4847

Merged
merged 13 commits into from
Mar 16, 2020
Merged

Return empty CSourceModule when no lowered_funcs exists in Relay mod #4847

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d6301d6
Use dummy func when no lowered_funcs exists in Relay mod
kumasento Feb 8, 2020
adbe5a2
Dummy func -> CSourceModule with empty code str
kumasento Feb 11, 2020
ca6e419
Added comments describing the empty CSouceModule
kumasento Feb 11, 2020
2b955fc
Merge branch 'master' into dev-relay-dummy
kumasento Feb 12, 2020
cbaa76c
Always import external modules w/o assertions
kumasento Feb 12, 2020
3e83a11
Use CSourceModule as a fallback for LLVMModule
kumasento Feb 13, 2020
a4f0d96
Changed cond for target == llvm
kumasento Feb 14, 2020
f1e8fed
Merge branch 'master' of https://github.com/dmlc/tvm into dev-relay-d…
kumasento Feb 17, 2020
d6656e2
Merge branch 'master' of https://github.com/dmlc/tvm into dev-relay-d…
kumasento Feb 28, 2020
9441c52
Create an empty LLVM module w/o using dummy func
kumasento Feb 28, 2020
ccded94
Avoid using IR str concat to create LLVM module
kumasento Mar 2, 2020
bb55935
Improved comments for codegen.LLVMModuleCreate
kumasento Mar 11, 2020
41450a5
Satisfy the linter for LLVMModuleCreate
kumasento Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/relay/backend/build_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <tvm/relay/qnn/transform.h>
#include <memory>

#include "../../target/source/codegen_source_base.h"
#include "utils.h"

namespace tvm {
Expand Down Expand Up @@ -438,13 +439,16 @@ class RelayBuildModule : public runtime::ModuleNode {

auto lowered_funcs = graph_codegen_->GetLoweredFunc();
if (lowered_funcs.size() == 0) {
LOG(WARNING) << "no lowered funcs exist in the compiled module";
// When there is no lowered_funcs generated, due to reasons such as optimization,
// a module with empty code content will be generated.
ret_.mod = tvm::codegen::CSourceModuleCreate("", "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the back and forth. Could you please add a comment here so that ppl would know what we are doing here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can force push so that your previous CI could be terminated earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, just added that

} else {
ret_.mod = tvm::build(
lowered_funcs,
target_host_,
BuildConfig::Current());
}

Array<tvm::runtime::Module> ext_mods = graph_codegen_->GetExternalModules();
if (!ext_mods.empty()) {
CHECK(lowered_funcs.size() > 0 || ext_mods.size() == 1)
Expand Down