Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object #4603

Merged
merged 3 commits into from
Dec 31, 2019
Merged

[REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal to Object #4603

merged 3 commits into from
Dec 31, 2019

Commits on Dec 31, 2019

  1. [REFACTOR][OBJECT] Consoldiate NodePtr/Ref/Hash/Equal and macros to O… 

    …bject.

Historically, we have classes like NodePtr/Ref/HashEqual.
After unified object protocol, these names are just alias of the object counterpart.
Moreover, there are helper macros defined over the places for defining these object.

This PR consoldiate the terminologies into the corresponding ones
in the Object system so we have a clean and consistent API moving forward.
    @tqchen
    tqchen committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    68375e7 View commit details
    Browse the repository at this point in the history

  2. Update include/tvm/attrs.h 

    Co-Authored-By: Wei Chen <ipondering.weic@gmail.com>
    @tqchen @wweic
    tqchen and wweic authored Dec 31, 2019
    Configuration menu
    Copy the full SHA
    0f66b43 View commit details
    Browse the repository at this point in the history

  3. fix compilation

    @tqchen
    tqchen committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    d082225 View commit details
    Browse the repository at this point in the history