Refactor bilinear and neighbour implementation in Tensorflow frontend #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is significant duplication between functions. Spotted while looking to move the tensorflow and tflite framework support to later than 1.13.1. The tests barf around resize_nearest_neighbour not ignoring the attribute 'helpful_pixel_centers'. That upgrade is a separate discussion while this can go in independently. Thanks, Ramana
|
Thanks @u99127 |
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Dec 13, 2019
…apache#4504) There is significant duplication between functions. Spotted while looking to move the tensorflow and tflite framework support to later than 1.13.1. The tests barf around resize_nearest_neighbour not ignoring the attribute 'helpful_pixel_centers'. That upgrade is a separate discussion while this can go in independently. Thanks, Ramana
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 13, 2019
…apache#4504) There is significant duplication between functions. Spotted while looking to move the tensorflow and tflite framework support to later than 1.13.1. The tests barf around resize_nearest_neighbour not ignoring the attribute 'helpful_pixel_centers'. That upgrade is a separate discussion while this can go in independently. Thanks, Ramana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is significant duplication between the functions.
Spotted while looking to move the tensorflow and tflite framework support to later than 1.13.1 and the tensorflow tests failing around resize_nearest_neighbour because the frontend doesn't ignore the attribute 'helpful_pixel_centers'.
That upgrade is a separate discussion while this can go in independently.
Thanks,
Ramana
@kevinthesun , could you please help review ?