[QNN] InferType changes that missed CI. #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2019
shoubhik
reviewed
Aug 15, 2019
| mod = relay.Module.from_expr(data[0]) | ||
| mod = relay.transform.InferType()(mod) | ||
| entry = mod["main"] | ||
| data0 = entry if isinstance(data[0], relay.Function) else entry.body |
There was a problem hiding this comment.
Why not use from ...frontend.common import infer_type. It seems unnecessary duplication of code. If the namespace is a problem we should probably move the existing method to a better place?
There was a problem hiding this comment.
Also, it seems the method from ...frontend.common import infer_type has more checks.
There was a problem hiding this comment.
It seems strange to import pass like infer_type from frontend. Should we consider create shortcut for infer_type? @jroesch
There was a problem hiding this comment.
Shortcut seems like a good idea.
Maybe, we can get this in to unblock CI and then follow up with another PR for shortcut and related changes to remove code duplication.
ZihengJiang
approved these changes
Aug 15, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Aug 16, 2019
anijain2305
added a commit
to anijain2305/tvm
that referenced
this pull request
Aug 22, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vinx13 @ZihengJiang
Added a quick fix to unblock CI. Will think about requantize default output_dtype to remove the dependence on InferType.