[Relay] [WIP] Add some missing primal gradients for Relay operators. #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sgrechanik-h @derisavi @ZihengJiang please help to review the PR when you have time. |
|
Thanks Altan; I'm not even sure I need correct gradients to do the work I'm trying to do, so any gradients at all is a big help! |
Closed
|
Superceded by #3506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on missing gradients from #2562, partially untested and broken. The tests need the patch in #3422 to run properly. Currently, the following new gradients should work:
The following are untested, but probably correct:
The following are definitely broken or semi-broken and will probably take some work to fix:
@jroesch @gussmith23