[Relay][Parser] simplify build script, remove python 2 support #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarisaKirisame
changed the title
|
As @zhiics suggested, do we also need to remove some of the auto-generated file in grammar/py3 ? |
|
@yzhliu I removed all the files in py3 and did a clean make. It also removed the .gitattributes but it didnt seem to be of any use. |
|
And we probably also what to update the .gitignore file to ignore the update of them, right? |
|
@zhiics the generated parser file is included, because we do not expect everyone working on relay to has ANTLR installed. This way only ppl modifying the parser need to install ANTLR. |
|
@yzhliu please followup on this PR |
yzhliu
approved these changes
Jun 28, 2019
yzhliu
added
status: accepted
and removed
status: need update
|
Thanks @MarisaKirisame @zhiics @tqchen |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 28, 2019
…e#3419) * simplify build script, remove python 2 support * remove py2 file * update py3
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 30, 2019
…e#3419) * simplify build script, remove python 2 support * remove py2 file * update py3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr remove the antlr jar finding process and use antlr4 directly instead.
Also, it remove python2 support for the parser, as tvm ditch python 2 suppoty.