Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoTVM] Fix a bug in simulated annealing #3413

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Conversation

merrymercy
Copy link
Member

Fix #3245

The simulated annealing is possible to return some dummy values . Although this bug is hardly triggered.

@merrymercy
Copy link
Member Author

cc @eqy @deadlywing

@@ -75,10 +75,10 @@ def find_maximums(self, model, num, exclusive):
scores = model.predict(points)

# build heap and insert initial points
heap_items = [(float('-inf'), -i) for i in range(num)]
heap_items = [(float('-inf'), - 1 - i) for i in range(num)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, world's worst nit

@merrymercy merrymercy merged commit 11441c1 into apache:master Jun 27, 2019
@merrymercy merrymercy deleted the fix-sa branch June 27, 2019 08:40
wweic pushed a commit to wweic/tvm that referenced this pull request Jun 28, 2019
* [AutoTVM] Fix a bug in simulated annealing

* Update sa_model_optimizer.py
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jun 30, 2019
* [AutoTVM] Fix a bug in simulated annealing

* Update sa_model_optimizer.py
@tqchen tqchen unassigned eqy Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[potential bug?] SimulatedAnnealingOptimizer will find useless candidate?
2 participants