Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target_host #3153

Closed
wants to merge 1 commit into from
Closed

Conversation

antinucleon
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

Copy link
Contributor

@hlu1 hlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for fp16

@zhiics
Copy link
Member

zhiics commented May 8, 2019

@antinucleon I will remove this function in #3144 and use target host there. Not sure if we still need this fix. But @hlu1 's comment is separate.

@antinucleon
Copy link
Contributor Author

@zhiics built-in fp16 is related to target_host. If target_host is not set correctly, fp16 may not be linked correctly. So you may need to add fp16 test to #3144

@antinucleon antinucleon closed this May 8, 2019
@zhiics
Copy link
Member

zhiics commented May 8, 2019

@antinucleon I can take a look at fp16 first. Probably I can add it in a separate PR.

@antinucleon antinucleon deleted the antinucleon-patch-1 branch May 22, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants