[Relay][OP] Gather_nd exposed to relay #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
reviewed
Apr 2, 2019
python/tvm/relay/frontend/mxnet.py
Outdated
| @@ -768,6 +773,7 @@ def _mx_deformable_convolution(inputs, attrs): | |||
| "SoftmaxOutput" : _mx_softmax_output, | |||
| "SoftmaxActivation" : _mx_softmax_activation, | |||
| "smooth_l1" : _mx_smooth_l1, | |||
| "gather_nd" : _mx_gather_nd, | |||
There was a problem hiding this comment.
You can put gather_nd in the _identity_list.
icemelon
reviewed
Apr 2, 2019
python/tvm/relay/frontend/mxnet.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| # pylint: disable=invalid-name, import-self, len-as-condition | |||
| # pylint: disable=invalid-name, import-self, len-as-condition, unused-argument | |||
There was a problem hiding this comment.
Don't need to disable this pylint if you put gather_nd in the identity_list
icemelon
approved these changes
Apr 2, 2019
|
Thanks @Laurawly |
ajtulloch
pushed a commit
to ajtulloch/tvm
that referenced
this pull request
Apr 5, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 8, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 10, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 11, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
ajtulloch
pushed a commit
to ajtulloch/tvm
that referenced
this pull request
Apr 25, 2019
* gather_nd added * gather_nd test added * more test added * fix lint * fix build error * fix lint * comments addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yzhliu Please review