Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Runtime] Implementation of Relay VM #2889

Merged
merged 30 commits into from
May 9, 2019
Merged

Conversation

jroesch
Copy link
Member

@jroesch jroesch commented Mar 25, 2019

This represents the culmination of #2810.

The final version of the VM adapts ideas from both proposals into a unified design.
This PR is work from @wweic @icemelon9 @zhiics and I.

Review please:

cc @joshpoll @weberlo @MarisaKirisame @slyubomirsky @tqchen @nhynes @ZihengJiang @junrushao1994

include/tvm/relay/vm/vm.h Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
Copy link
Contributor

@wweic wweic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get some unnecessary diffs out first.

src/relay/backend/interpreter.cc Show resolved Hide resolved
python/tvm/relay/frontend/tensorflow.py Outdated Show resolved Hide resolved
python/tvm/relay/prelude.py Outdated Show resolved Hide resolved
@jroesch jroesch force-pushed the relay-rts branch 2 times, most recently from 1d28c24 to 02c0823 Compare March 26, 2019 08:49
@jroesch jroesch marked this pull request as ready for review April 12, 2019 23:59
@jroesch jroesch force-pushed the relay-rts branch 2 times, most recently from b4f7b73 to 59181eb Compare April 16, 2019 01:59
include/tvm/relay/expr.h Outdated Show resolved Hide resolved
python/tvm/relay/__init__.py Outdated Show resolved Hide resolved
python/tvm/relay/_vm.py Outdated Show resolved Hide resolved
python/tvm/relay/module.py Outdated Show resolved Hide resolved
python/tvm/relay/ty.py Outdated Show resolved Hide resolved
src/relay/ir/type_functor.cc Outdated Show resolved Hide resolved
src/relay/pass/fuse_ops.cc Outdated Show resolved Hide resolved
src/relay/pass/kind_check.cc Outdated Show resolved Hide resolved
src/relay/pass/type_infer.cc Outdated Show resolved Hide resolved
python/tvm/relay/frontend/mxnet.py Outdated Show resolved Hide resolved
src/relay/op/tensor/reduce.cc Outdated Show resolved Hide resolved
src/relay/pass/dead_code.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/lambda_lift.cc Outdated Show resolved Hide resolved
src/relay/vm/lambda_lift.cc Outdated Show resolved Hide resolved
src/relay/vm/lambda_lift.cc Outdated Show resolved Hide resolved
src/relay/vm/lambda_lift.cc Outdated Show resolved Hide resolved
src/relay/vm/vm.cc Outdated Show resolved Hide resolved
@MarisaKirisame
Copy link
Contributor

I had do a quick review and will do a more through one later.
This is a good time to discuss GC because we has cyclic data structure.

include/tvm/relay/vm/vm.h Outdated Show resolved Hide resolved
include/tvm/runtime/object.h Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/inline_primitives.cc Outdated Show resolved Hide resolved
src/relay/vm/vm.cc Outdated Show resolved Hide resolved
src/relay/vm/vm.cc Outdated Show resolved Hide resolved
src/relay/vm/vm.cc Outdated Show resolved Hide resolved
src/relay/vm/lambda_lift.cc Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented Apr 17, 2019

include/tvm/relay/vm/vm.h Outdated Show resolved Hide resolved
include/tvm/relay/vm/vm.h Outdated Show resolved Hide resolved
include/tvm/relay/vm/vm.h Outdated Show resolved Hide resolved
src/relay/pass/to_a_normal_form.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
src/relay/vm/compiler.cc Outdated Show resolved Hide resolved
docs/dev/virtual_machine.rst Outdated Show resolved Hide resolved
docs/dev/virtual_machine.rst Outdated Show resolved Hide resolved
docs/dev/virtual_machine.rst Outdated Show resolved Hide resolved
docs/dev/virtual_machine.rst Outdated Show resolved Hide resolved
docs/dev/virtual_machine.rst Outdated Show resolved Hide resolved
python/tvm/_ffi/function.py Outdated Show resolved Hide resolved
src/relay/pass/fuse_ops.cc Outdated Show resolved Hide resolved
src/relay/pass/fuse_ops.cc Outdated Show resolved Hide resolved
docs/dev/virtual_machine.rst Outdated Show resolved Hide resolved
python/tvm/_ffi/function.py Outdated Show resolved Hide resolved
@jroesch jroesch merged commit 4332b0a into apache:master May 9, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
* Implement the virtual machine

Co-Authored-By: wweic <ipondering.weic@gmail.com>

* Fix rebase build issues

* Reorganize vm.py and fix allocator bug

* Remove compiler

* Remove tests

* Remove backend/vm/vm.cc too

* Fix docs

* Fix doc

* Fix doc

* Add vm docs

* Remove change to dead_code.cc

* Remove Relay logging

* Remove reduce

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Reformat

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Address feedback

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Apply suggestions from code review

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Fix a couple outstanding comments

* Last couple comments

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Address code review feedback

* Fix final comment

* Address comments

* Error reporting and example

* add Const

* Explicitly delete copy assignment operator

* Fix rebase

* Pass 3rd arg to fusion
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
* Implement the virtual machine

Co-Authored-By: wweic <ipondering.weic@gmail.com>

* Fix rebase build issues

* Reorganize vm.py and fix allocator bug

* Remove compiler

* Remove tests

* Remove backend/vm/vm.cc too

* Fix docs

* Fix doc

* Fix doc

* Add vm docs

* Remove change to dead_code.cc

* Remove Relay logging

* Remove reduce

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Reformat

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Address feedback

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Apply suggestions from code review

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Fix a couple outstanding comments

* Last couple comments

* Update include/tvm/runtime/vm.h

Co-Authored-By: jroesch <roeschinc@gmail.com>

* Address code review feedback

* Fix final comment

* Address comments

* Error reporting and example

* add Const

* Explicitly delete copy assignment operator

* Fix rebase

* Pass 3rd arg to fusion
@jroesch jroesch deleted the relay-rts branch February 4, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants