[Relay][OP] Fix bias_add default axis #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
reviewed
Mar 16, 2019
|
@junrushao1994 I'm investigating whether we should go with this change... I realize that bias_add with default axis=1 works good with conv, but requires batch flatten for dense op. I'll follow up on this pr in a few days. |
|
any update? |
|
I decide to change the MXNet converter to explicit set axis=-1 in the bias_add. |
|
It looks good. Let's wait for the CI to complete |
|
@junrushao1994 @jroesch CI has passed. Could you help review the pr? |
icemelon
added
status: need review
and removed
status: need update
jroesch
approved these changes
Apr 2, 2019
ajtulloch
pushed a commit
to ajtulloch/tvm
that referenced
this pull request
Apr 5, 2019
* Fix bias add default axis * update * Fix canonicalize ops for bias_add
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
* Fix bias add default axis * update * Fix canonicalize ops for bias_add
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 7, 2019
* Fix bias add default axis * update * Fix canonicalize ops for bias_add
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 8, 2019
* Fix bias add default axis * update * Fix canonicalize ops for bias_add
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 10, 2019
* Fix bias add default axis * update * Fix canonicalize ops for bias_add
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 11, 2019
* Fix bias add default axis * update * Fix canonicalize ops for bias_add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default axis in bias_add from 1 to -1