[Lang] Layout in TVM node system #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(), add defined() checker
|
@yzhliu do you mind summarize the discuss thread a bit and open an formal RFC issue? |
|
@tqchen sure, will do. |
|
I'll start to review after RFC is out. |
kevinthesun
reviewed
Feb 14, 2019
merrymercy
reviewed
Feb 19, 2019
|
Only some minors, generally looks good to me |
|
LGTM as long as we add topi layout_transform. |
merrymercy
added
status: need update
tqchen
requested changes
Feb 24, 2019
|
@kevinthesun @merrymercy @tqchen Thanks for feedback. Comments addressed, please review again. |
merrymercy
approved these changes
Feb 27, 2019
tqchen
requested changes
Feb 27, 2019
include/tvm/layout.h
Outdated
| * \brief Layout expression to describe the data organization of a tensor. | ||
| * And BijectiveLayout to mapping two data layouts between each other. | ||
| */ | ||
| #ifndef TVM_LAYOUT_H_ |
There was a problem hiding this comment.
How about we rename layout.h ->data_layout just to make the header name clear, we do not have to rename anything in the class
tqchen
approved these changes
Feb 27, 2019
|
Have one comment on changing layout.h->data_layout.h otherwise lgtm, will leave it to @merrymercy for moderation |
|
@tqchen @merrymercy @kevinthesun Comment addressed. Please check again. |
|
@tqchen @yzhliu @kevinthesun Thanks. It is merged |
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
* move layout.h & layout.cc from relay to tvm * change ConvertLayout in relay to bijectiveLayout->Forward/backward * add first test case * add LayoutAxis * add LayoutAxis struct and compiles * simplify BijectiveLayout rule consturct * polish func name for Layout, move impl to .cc, remove Layout::defined(), add defined() checker * partially add layout py support * add layout test cases * add doc for tvm.layout & tvm.bijective_layout * fix lint * fix lint * fix layout name generation bug * fix layout typo * address comments and add topi.layout_transform * layout.h->data_layout.h, test_lang_layout.py->test_lang_data_layout.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
* move layout.h & layout.cc from relay to tvm * change ConvertLayout in relay to bijectiveLayout->Forward/backward * add first test case * add LayoutAxis * add LayoutAxis struct and compiles * simplify BijectiveLayout rule consturct * polish func name for Layout, move impl to .cc, remove Layout::defined(), add defined() checker * partially add layout py support * add layout test cases * add doc for tvm.layout & tvm.bijective_layout * fix lint * fix lint * fix layout name generation bug * fix layout typo * address comments and add topi.layout_transform * layout.h->data_layout.h, test_lang_layout.py->test_lang_data_layout.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* move layout.h & layout.cc from relay to tvm * change ConvertLayout in relay to bijectiveLayout->Forward/backward * add first test case * add LayoutAxis * add LayoutAxis struct and compiles * simplify BijectiveLayout rule consturct * polish func name for Layout, move impl to .cc, remove Layout::defined(), add defined() checker * partially add layout py support * add layout test cases * add doc for tvm.layout & tvm.bijective_layout * fix lint * fix lint * fix layout name generation bug * fix layout typo * address comments and add topi.layout_transform * layout.h->data_layout.h, test_lang_layout.py->test_lang_data_layout.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* move layout.h & layout.cc from relay to tvm * change ConvertLayout in relay to bijectiveLayout->Forward/backward * add first test case * add LayoutAxis * add LayoutAxis struct and compiles * simplify BijectiveLayout rule consturct * polish func name for Layout, move impl to .cc, remove Layout::defined(), add defined() checker * partially add layout py support * add layout test cases * add doc for tvm.layout & tvm.bijective_layout * fix lint * fix lint * fix layout name generation bug * fix layout typo * address comments and add topi.layout_transform * layout.h->data_layout.h, test_lang_layout.py->test_lang_data_layout.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC we introduce Layout into TVM node system, and remove that from Relay.
Reviewers Please help to review @kevinthesun @merrymercy @tqchen