Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND][TENSORFLOW] Simplify input shape #2242

Merged
merged 1 commit into from
Dec 29, 2018
Merged

[FRONTEND][TENSORFLOW] Simplify input shape #2242

merged 1 commit into from
Dec 29, 2018

Conversation

alexeyr
Copy link
Contributor

@alexeyr alexeyr commented Dec 6, 2018

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

Depends on #2105.

@alexeyr
Copy link
Contributor Author

alexeyr commented Dec 6, 2018 •
edited
Loading

This gives some warnings when running tests, like

[14:16:31] /workspace/src/romanov/tvm/src/schedule/bound.cc:110: not in feed graph consumer = compute(input0_red_temp, 0x478efb0)
[14:16:31] /workspace/src/romanov/tvm/src/schedule/bound.cc:110: not in feed graph consumer = compute(input0_red_temp, 0x478efb0)

and

WARNING:autotvm:Cannot find config for target=llvm, workload=('conv2d', (4, 8, 8, 176, 'float32'), (1, 1, 176, 32, 'float32'), (1, 1), (0, 0), (1, 1), 'NHWC', 'float32'). A fallback configuration is used, which may bring great performance regression.

I guess the second should be fixed by modifying AutoTVM lookup, but I don't know about the first.

@alexeyr alexeyr changed the title [FRONTEND][TENSORFLOW] Simplify input shape [WIP][FRONTEND][TENSORFLOW] Simplify input shape Dec 6, 2018
@alexeyr alexeyr force-pushed the from_tensorflow_simplify_input_shape branch from a5738b7 to 23a10d3 Compare December 12, 2018 07:29
@icemelon
Copy link
Member

@alexeyr Could you resolve the conflicts to latest master?

@icemelon icemelon added the status: need update need update based on feedbacks label Dec 21, 2018
@srkreddy1238
Copy link
Contributor

@alexeyr changes related to Unstack and Split(V) are already merged.
I think input_shape simplification may not be required as a node may have multiple outputs.

@alexeyr alexeyr force-pushed the from_tensorflow_simplify_input_shape branch from 23a10d3 to d641aee Compare December 27, 2018 07:59
@alexeyr
Copy link
Contributor Author

alexeyr commented Dec 27, 2018

@icemelon9 Updated.
@srkreddy1238 This is taken into account: even if a node has multiple outputs, each input of another node uses only one of them and we still have a 1-element list there: https://github.com/dmlc/tvm/blob/021099f8d7d9cc59ae9ee872edde45803983d45c/nnvm/python/nnvm/frontend/tensorflow.py#L1235-L1243.

@alexeyr
Copy link
Contributor Author

alexeyr commented Dec 27, 2018 •
edited
Loading

@srkreddy1238 Yes, this pull request doesn't fix any bugs, it is intended to simplify code while producing the exact same result. I've now verified that it actually does that:

I get the

...int_set.cc:514: cannot evaluate set type Cast

and other warnings when running the tests from IPython on the first try and don't get them after repeating. This happens both in master and with this pull request.

I also saved JSON of all graphs produced by test_forward.py and verified they are the same before and after the change.

Can you please review?

@alexeyr alexeyr changed the title [WIP][FRONTEND][TENSORFLOW] Simplify input shape [FRONTEND][TENSORFLOW] Simplify input shape Dec 27, 2018
srkreddy1238
srkreddy1238 approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeyr Thanks. LGTM.

@srkreddy1238 srkreddy1238 merged commit f6c3f99 into apache:master Dec 29, 2018
@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Dec 29, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Jan 10, 2019
@alexeyr @srkreddy1238
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element…
c5a2bd9 
… lists (apache#2242)
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@alexeyr
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element…
e8eba8b 
… lists (apache#2242)
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@alexeyr
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element…
8ccb412 
… lists (apache#2242)
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 9, 2019
@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
094d4be 
commit f347b52
Author: Yong Wu <yongwu@amazon.com>
    Get tags of saved model automatically

commit 916576c
Author: Zhi Chen <chzhi@amazon.com>
    Support TensorFlow saved model
    TF parser: return the consistent error message to error handler

commit f1782f3
Author: Yong Wu <yongwu@amazon.com>
    Add tf parser wrapper, infer shape automatically

commit 76188a4
Author: Siva <sivar.b@huawei.com>
    [NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi <ashutosh.parkhi@imgtec.com>
    [Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov <alexey.v.romanov@gmail.com>
    [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes <36929632+dominicsymes@users.noreply.github.com>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov <alexey.v.romanov@gmail.com>
    [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva <sivar.b@huawei.com>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin <zhebin.jzb@alibaba-inc.com>
    [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
    * Add Split and realdiv op support
    * Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 9, 2019
@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
cde0dc6 
commit f347b52
Author: Yong Wu <yongwu@amazon.com>
    Get tags of saved model automatically

commit 916576c
Author: Zhi Chen <chzhi@amazon.com>
    Support TensorFlow saved model
    TF parser: return the consistent error message to error handler

commit f1782f3
Author: Yong Wu <yongwu@amazon.com>
    Add tf parser wrapper, infer shape automatically

commit 76188a4
Author: Siva <sivar.b@huawei.com>
    [NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi <ashutosh.parkhi@imgtec.com>
    [Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov <alexey.v.romanov@gmail.com>
    [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes <36929632+dominicsymes@users.noreply.github.com>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov <alexey.v.romanov@gmail.com>
    [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva <sivar.b@huawei.com>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin <zhebin.jzb@alibaba-inc.com>
    [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
    * Add Split and realdiv op support
    * Fix the pad calculation in the case of dilated convolution
@srkreddy1238 srkreddy1238 mentioned this pull request Mar 9, 2019
Merged
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 9, 2019
@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
566f2c1 
commit f347b52
Author: Yong Wu <yongwu@amazon.com>
    Get tags of saved model automatically

commit 916576c
Author: Zhi Chen <chzhi@amazon.com>
    Support TensorFlow saved model
    TF parser: return the consistent error message to error handler

commit f1782f3
Author: Yong Wu <yongwu@amazon.com>
    Add tf parser wrapper, infer shape automatically

commit 76188a4
Author: Siva <sivar.b@huawei.com>
    [NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi <ashutosh.parkhi@imgtec.com>
    [Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov <alexey.v.romanov@gmail.com>
    [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes <36929632+dominicsymes@users.noreply.github.com>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov <alexey.v.romanov@gmail.com>
    [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva <sivar.b@huawei.com>
    [FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin <zhebin.jzb@alibaba-inc.com>
    [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
    * Add Split and realdiv op support
    * Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 11, 2019
@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
4b639b5 
commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this pull request Mar 12, 2019
@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
686da01 
commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
srkreddy1238 added a commit that referenced this pull request Mar 19, 2019
@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. (#2757)
bb3c815 
* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.

commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (#2444)

commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (#2285)

commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242)

commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (#2326)

commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (#2105)

commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (#2267)

commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

* 	* review comments

* 	* resnet fix.

* 	* review comments
wweic pushed a commit to wweic/tvm that referenced this pull request Mar 20, 2019
@srkreddy1238 @wweic
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. (apa…
d8d2538 
…che#2757)

* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.

commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

* 	* review comments

* 	* resnet fix.

* 	* review comments
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 20, 2019
@srkreddy1238 @wweic
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. (apa…
ec7acb9 
…che#2757)

* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.

commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)

commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)

commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)

commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)

commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)

commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)

commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

* 	* review comments

* 	* resnet fix.

* 	* review comments
@tqchen tqchen mentioned this pull request Dec 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srkreddy1238 srkreddy1238 srkreddy1238 approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeyr @icemelon @srkreddy1238 @tqchen